Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Create vote" notice #1032

Closed
wants to merge 1 commit into from
Closed

Update "Create vote" notice #1032

wants to merge 1 commit into from

Conversation

john-light
Copy link
Contributor

  • A "yes" vote is no longer automatically cast when a vote is created

@john-light
Update "Create vote" notice
50a03da 
- A "yes" vote is no longer automatically cast when a vote is created
@auto-assign auto-assign bot requested a review from bpierre November 2, 2019 23:59
@sohkai
Copy link
Contributor

sohkai commented Nov 4, 2019 •
edited
Loading

This is not necessarily true; it does automatically vote 'yes' if the forwarder has voting tokens. The problem is essentially the same as #537.

The fact that this is confusing is tricky; but technically we could try to check for token balances here while interpolating the string: #1033

@sohkai sohkai closed this Nov 4, 2019
@sohkai sohkai deleted the john-light-patch-1 branch November 4, 2019 14:55
@sohkai sohkai mentioned this pull request Nov 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai Awaiting requested review from sohkai

@bpierre bpierre Awaiting requested review from bpierre

Assignees
No one assigned
Labels
app: voting component: contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-light @sohkai