fix(nodejs): fix infinite loop when package link from package-lock.json file is broken
#6858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Jun 5, 2024
| @@ -208,7 +216,8 @@ func (p *Parser) resolveLinks(packages map[string]Package) { | |||
| } | |||
|
|
|||
| workspaces := rootPkg.Workspaces | |||
| for pkgPath, pkg := range packages { | |||
| // Clone packages to avoid cases when we check already updated packages | |||
There was a problem hiding this comment.
Could you elaborate on that?
There was a problem hiding this comment.
We update packages map inside of packages loop.
trivy/pkg/dependency/parser/nodejs/npm/parse.go
Lines 232 to 235 in a2d1871
this is bad practice.
When I tested broken link with empty resolved field - this loop would endlessly update packages, check them and we get out of memory error.
There was a problem hiding this comment.
Can we change the comment to something like "Changing the map during the map iteration causes unexpected behavior" for clarity?
There was a problem hiding this comment.
Yeah, it make sense.
Updated in b8e52c4
2 tasks
knqyf263
approved these changes
Jun 10, 2024
|
@aqua-bot backport release/v0.52 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…son` file is broken (#6858)
|
Backport PR created: #6888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 2 cases:
Packages[x].resolvedis empty for link - we don't need to resolve this link.packagesmap when resolving links to avoid cases when we updated package is parsed.Related issues
Checklist