Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle): Improve handling and reporting of vulnerabilities between normal, FIPS, and ksplice package variants #2273

Closed
wants to merge 4 commits into from

Conversation

bpfoster
Copy link

@bpfoster bpfoster commented Jun 6, 2022

Description

Check the installed version and the fix version to see if they're both for the FIPS package or not.

Before:

┌────────────────┬────────────────┬──────────┬─────────────────────┬──────────────────────────┬─────────────────────────────────────────────────────────────┐
│    Library     │ Vulnerability  │ Severity │  Installed Version  │      Fixed Version       │                            Title                            │
├────────────────┼────────────────┼──────────┼─────────────────────┼──────────────────────────┼─────────────────────────────────────────────────────────────┤
│ gnutls         │ CVE-2021-20231 │ MEDIUM   │ 3.6.14-8.el8_3      │ 10:3.6.16-4.0.1.el8_fips │ gnutls: Use after free in client key_share extension        │
│                │                │          │                     │                          │ https://avd.aquasec.com/nvd/cve-2021-20231                  │
├────────────────┼────────────────┼──────────┼─────────────────────┼──────────────────────────┼─────────────────────────────────────────────────────────────┤
│ gnutls         │ CVE-2021-20232 │ MEDIUM   │ 3.6.14-8.el8_3      │ 10:3.6.16-4.0.1.el8_fips │ gnutls: Use after free in client_send_params in             │
│                │                │          │                     │                          │ lib/ext/pre_shared_key.c                                    │
│                │                │          │                     │                          │ https://avd.aquasec.com/nvd/cve-2021-20232                  │
│                ├────────────────┤          │                     │                          ├─────────────────────────────────────────────────────────────┤
│                │ CVE-2021-3580  │          │                     │                          │ nettle: Remote crash in RSA decryption via manipulated      │
│                │                │          │                     │                          │ ciphertext                                                  │
│                │                │          │                     │                          │ https://avd.aquasec.com/nvd/cve-2021-3580                   │
├────────────────┼────────────────┼──────────┼─────────────────────┼──────────────────────────┼─────────────────────────────────────────────────────────────┤

After:

┌────────────────────────┬────────────────┬──────────┬─────────────────────┬──────────────────────┬──────────────────────────────────────────────────────────────┐
│        Library         │ Vulnerability  │ Severity │  Installed Version  │    Fixed Version     │                            Title                             │
├────────────────────────┼────────────────┼──────────┼─────────────────────┼──────────────────────┼──────────────────────────────────────────────────────────────┤
│ gnutls                 │ CVE-2021-20231 | MEDIUM   │ 3.6.14-8.el8_3      │ 3.6.16-4.el8         │ gnutls: Use after free in client key_share extension         │
│                        │                │          │                     │                      │ https://avd.aquasec.com/nvd/cve-2021-20231                   │
├────────────────────────┼────────────────┼──────────┼─────────────────────┼──────────────────────┼──────────────────────────────────────────────────────────────┤
│ gnutls                 │ CVE-2021-20232 │ MEDIUM   │ 3.6.14-8.el8_3      │ 3.6.16-4.el8         │ gnutls: Use after free in client_send_params in              │
│                        │                │          │                     │                      │ lib/ext/pre_shared_key.c                                     │
│                        │                │          │                     │                      │ https://avd.aquasec.com/nvd/cve-2021-20232                   │
│                        ├────────────────┤          │                     │                      ├──────────────────────────────────────────────────────────────┤
│                        │ CVE-2021-3580  │          │                     │                      │ nettle: Remote crash in RSA decryption via manipulated       │
│                        │                │          │                     │                      │ ciphertext                                                   │
│                        │                │          │                     │                      │ https://avd.aquasec.com/nvd/cve-2021-3580                    │
├────────────────────────┼────────────────┼──────────┼─────────────────────┼──────────────────────┼──────────────────────────────────────────────────────────────┤

Note that this has a dependency on trivy-db PR #221 for correct results (updated database schema) and usage of a newly exported oracleoval.GetPackageFlavor function.

oracleoval.GetPackageFlavor fixes flavor handling in Oracle packages:

  • FIPS validated packages handling is added
  • ksplice packages handling is fixed. ksplice1 and ksplice2 are not separate flavors. ksplice is the flavor and the number after it is a ksplice userspace code release number.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@bpfoster bpfoster requested a review from knqyf263 as a code owner June 6, 2022 17:40
@bpfoster bpfoster marked this pull request as draft June 9, 2022 20:37
@bpfoster bpfoster changed the title fix(oracle): Check to see if advisory and package match for fips mode fix(oracle): Improve handling and reporting of vulnerabilities between normal, FIPS, and ksplice package variants Jun 23, 2022
@github-actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 23, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 30, 2022
@github-actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label May 17, 2023
@github-actions github-actions bot closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positives being reported from Trivy 0.24.2 - oraclelinux:8 image
2 participants