Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all linting errors + remove dependencies #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marwan-at-work
Copy link

@marwan-at-work marwan-at-work commented Apr 18, 2022

Hi there, thanks for writing this plugin. This PR does a few things:

  1. Adds Go Modules support.
  2. Fixes a lot of the "old dart" code to make it more up to date with today's dart (no new keyword for example, amongst others).
  3. Remove the dependency on twirp_dart_core and requester as they are just two files that can be included along with the protobuf generator
  4. Fixes an error/bug with int64 as it gets encoded as a string when using json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant