-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http-netty: let RetryingHttpRequesterFilter return responses on failure #3048
Open
bryce-anderson
wants to merge
11
commits into
apple:main
Choose a base branch
from
bryce-anderson:bl_anderson/RetryingHttpRequesterCanReturnRepsonses
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
http-netty: let RetryingHttpRequesterFilter return responses on failure #3048
bryce-anderson
wants to merge
11
commits into
apple:main
from
bryce-anderson:bl_anderson/RetryingHttpRequesterCanReturnRepsonses
Commits on Aug 22, 2024
-
http-netty: let RetryingHttpRequesterFilter return responses on failure
Motivation: Sometimes people just want to get the last failed response when the retry loop ends. However, right now we only yield the exceptions that where created. Users can't do this smuggling themselves in a generic way via the HttpResponseException because it could lead to resource leaks. Modifications: Let users simply return the last failed response when the retry loop exits unsuccessfully.
Configuration menu - View commit details
-
Copy full SHA for 515dd29 - Browse repository at this point
Copy the full SHA 515dd29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b7f014 - Browse repository at this point
Copy the full SHA 5b7f014View commit details -
Configuration menu - View commit details
-
Copy full SHA for b08742d - Browse repository at this point
Copy the full SHA b08742dView commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b4b60c - Browse repository at this point
Copy the full SHA 4b4b60cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3493dc4 - Browse repository at this point
Copy the full SHA 3493dc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e80e98e - Browse repository at this point
Copy the full SHA e80e98eView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6ba45bc - Browse repository at this point
Copy the full SHA 6ba45bcView commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6b45aa8 - Browse repository at this point
Copy the full SHA 6b45aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49d272d - Browse repository at this point
Copy the full SHA 49d272dView commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f25458c - Browse repository at this point
Copy the full SHA f25458cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d07708 - Browse repository at this point
Copy the full SHA 8d07708View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.