Feature vite #121
Open
Feature vite #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myovchev
commented
Oct 29, 2024
package.json
Outdated
| @@ -21,6 +21,7 @@ | |||
| "author": "Apostrophe Technologies", | |||
| "license": "UNLICENSED", | |||
| "dependencies": { | |||
| "@apostrophecms/vite": "github:apostrophecms/vite", | |||
There was a problem hiding this comment.
FIXME: change to actual version after release.
myovchev
commented
Oct 29, 2024
package.json
Outdated
| @@ -32,7 +33,7 @@ | |||
| "@opentelemetry/semantic-conventions": "^1.24.1", | |||
| "@tiptap/extension-text-style": "^2.4.0", | |||
| "accordion-js": "^3.3.4", | |||
| "apostrophe": "^4.5.2", | |||
| "apostrophe": "github:apostrophecms/apostrophe", | |||
There was a problem hiding this comment.
FIXME: change to actual version after release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Vite build module. Fix Sass imports. Update the bundle configuration to work with both Webpack and Vite.
A beta feature, until @apostrophecms/vite is marked as stable.
What are the specific steps to test this change?
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: