Pro 6419 import pages #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroun
commented
Sep 3, 2024
package.json
Outdated
| @@ -18,14 +18,15 @@ | |||
| "author": "Apostrophe Technologies", | |||
| "license": "UNLICENSED", | |||
| "devDependencies": { | |||
| "apostrophe": "github:apostrophecms/apostrophe", | |||
| "apostrophe": "github:apostrophecms/apostrophe#pro-6425-batch-operation-page", | |||
* pro-6436-batch-operation-page: Fix import labels for singleton pieces Fix missing module action Changelog Add batch label for notificaitons Ensure unique types Add computed documents types Add export batch operation for pages
boutell
approved these changes
Sep 4, 2024
* pro-6436-batch-operation-page: Add replaces configuration for singleton import menu
myovchev
approved these changes
Sep 4, 2024
| @@ -303,23 +307,34 @@ module.exports = self => { | |||
| // If the parked/singleton doc is not found, it should be processed as a | |||
| // regular doc. | |||
| if (isSingleton || parkedId) { | |||
| // TODO: what about singleton with localized = false, we don't have aposMode | |||
| // TODO: do I need that for parked page? | |||
There was a problem hiding this comment.
I don't think this is a problem. aposMode in my knowledge always exists (no matter localized or not). We check for draft here because we want to trigger this (expensive) code only once per unique page (aposDocId).
| }) | ||
| : null; | ||
| if (replaceId) { | ||
| // NOTE: please update duplicatedDocs launder in overrideDuplicates |
…recomputeAllDocReferences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: