Pro 6416 missing fields #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
force-pushed
the
pro-6416-missing-fields
branch
from
fd28dcd
to
eef7fe6
Compare
ValJed
force-pushed
the
pro-6416-missing-fields
branch
from
eef7fe6
to
f13c0fa
Compare
ValJed
commented
Aug 26, 2024
| recursions++; | ||
| if (recursions >= MAX_RECURSION) { | ||
| return related; | ||
| } |
There was a problem hiding this comment.
Not sure we need this recursion limit since we parse each type schema only once.
ValJed
commented
Aug 26, 2024
| @@ -229,7 +229,7 @@ export default { | |||
| this.relatedTypes = await apos.http.get('/api/v1/@apostrophecms/import-export/related', { | |||
| busy: true, | |||
| qs: { | |||
| type: this.type | |||
| types: [ this.type ] | |||
There was a problem hiding this comment.
New related route takes an array of types (for future pages implementation).
There was a problem hiding this comment.
could be good to test the route in addition of the method, but lgtm
myovchev
approved these changes
Aug 26, 2024
ETLaurent
approved these changes
Aug 27, 2024
| @@ -229,7 +229,7 @@ export default { | |||
| this.relatedTypes = await apos.http.get('/api/v1/@apostrophecms/import-export/related', { | |||
| busy: true, | |||
| qs: { | |||
| type: this.type | |||
| types: [ this.type ] | |||
There was a problem hiding this comment.
could be good to test the route in addition of the method, but lgtm
ETLaurent
reviewed
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRO-6416
Summary
findForEditingto get related documents instead of taking them directly from exported docs. This way data exported isn't limited to projections.relatedroutes, also checks related types of related types. Ex: if your exported piece is an article with relations to images, before the related modal wouldn't have proposedimage-tag(relation of images) now it does.What are the specific steps to test this change?
Related modal should should also show the related types of the exported document related documents. Still have a recursion level limit of 10 (that is probably useless).
Let's say you have articles and topics.
Topics has projections.
Export an article with a relation to a topic.
It should export the entire topic not only projected fields
Cypress tests: 🟠
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: