Add a scrollbar to the duplicate import modal #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ETLaurent
requested changes
Jul 26, 2024
| @@ -323,6 +325,15 @@ export default { | |||
| display: flex; | |||
| flex-direction: column; | |||
| align-items: baseline; | |||
| max-height: 50vh; | |||
There was a problem hiding this comment.
Suggested change
| max-height: 50vh; | |
| max-height: 210px; |
In order to keep the same max-height as the related types modal
| @@ -21,31 +21,33 @@ | |||
|
|
|||
| <div class="apos-import-duplicate__section"> | |||
| <table class="apos-table"> | |||
| <thead> | |||
Comment on lines
333
to
336
| position: sticky; | ||
| top: 0; | ||
| z-index: 1; | ||
| backgroud-color: var(--a-base-10); |
There was a problem hiding this comment.
Suggested change
| position: sticky; | |
| top: 0; | |
| z-index: 1; | |
| backgroud-color: var(--a-base-10); | |
| position: sticky; | |
| top: 0; | |
| background-color: var(--a-background-primary); |
sticky, good stuff.- no need for z-index it appears
- please change background color to white (
var(--a-background-primary)) and fix typo
CHANGELOG.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.3.0 (2024-07-24) | |||
There was a problem hiding this comment.
Suggested change
| ## 2.3.0 (2024-07-24) | |
| ## UNRELEASED |
We will set the version and the date when we will release the module
ETLaurent
reviewed
Jul 26, 2024
| @@ -243,7 +245,7 @@ export default { | |||
| : this.duplicatedDocs.map(({ aposDocId }) => aposDocId); | |||
| }, | |||
| docLabel(doc) { | |||
| const moduleOptions = apos.modules[this.type]; | |||
| const moduleOptions = apos.modules[doc.type]; | |||
|
Changes are done now. |
…-duplicate-imports-modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The apostrophe duplicate imports modal component displays a table of all duplicated docs, that can overflow the visible area when there are too many duplicates (> 50). To improve usability, I added a vertical scrollbar with a maximum height of 50vh to the table body and introduce a sticky thead to keep the table headers visible while scrolling.
I also fixed the type column values: Previously, only 'Page' was displayed, regardless of the actual document type. With this fix, the correct document type will now be displayed in the type column, ensuring accurate representation of each document's type.
What are the specific steps to test this change?
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: