Add option to prevent updating assets on import #69
Conversation
|
|
||
| ### Adds | ||
|
|
||
| * Adds a `preventUpdateAssets` to the module that will not try to update already existing assets on import. |
There was a problem hiding this comment.
You are right to want this to change, because it is doing a great deal of extra work, but the actual fix is different... attachments are immutable, except for crops, docIds and archivedDocIds. Therefore the file itself should never need to be re-uploaded, although some crops present in the imported database might need to be inserted, which I don't see happening in the existing code.
So I will discuss with the team, I think this would make more sense as a warranty issue in gitlab.
My fault perhaps for making attachments do so much complicated bookkeeping to avoid copies, but copies are very expensive when multiplied across all modes and locales.
There was a problem hiding this comment.
Approving this in its current form as an important workaround for a special case that has since been explained to me: because of the limitation currently in place that the entire upload must fit in a single POST request, their team is using smaller images as placeholders during imports, but they cannot afford to have these replacing existing images they already swapped out for full size.
We have an internal ticket on our roadmap to work around the POST limit in the future.
Summary
Adds an option to prevent updating attachments if they already exist.
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: