-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro 4257 modal property #2
Conversation
PRO-4257 As a developer, I can use the modal property in my batch operations
Like for the method
This way, when clicking on the batch operation button, will be able to open a specific modal for more specific and complex behaviors. We'll need this feature to be able to open the same export modal when clicking on the You can base your work on the way it works currently for the Acceptance Criteria
|
@@ -22,6 +22,6 @@ module.exports = { | |||
}; | |||
} | |||
|
|||
self.apos.doc.addContextOperation(self.__meta.name, criteria); | |||
self.apos.doc.addContextOperation(criteria); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
criteria is not a good name for this. operation
would be good.
Summary
https://linear.app/apostrophecms/issue/PRO-4257/as-a-developer-i-can-use-the-modal-property-in-my-batch-operations
What are the specific steps to test this change?
The modal should be the same. It will be completed in another ticket.