refactor remove functions

apostrophecms · Apr 11, 2024 · 86df216 · 86df216
1 parent 24704ef
commit 86df216
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 31 deletions.
diff --git a/lib/methods/export.js b/lib/methods/export.js
@@ -367,15 +367,6 @@ module.exports = self => {
       }
     },
 
-    async remove(filepath) {
-      console.info(`[export] removing ${filepath}`);
-      try {
-        await fsp.unlink(filepath);
-      } catch (error) {
-        self.apos.util.error(error);
-      }
-    },
-
     // Report is available for 10 minutes by default
     removeFromUploadFs(downloadPath, expiration) {
       const ms = expiration || 1000 * 60 * 10;

diff --git a/lib/methods/import.js b/lib/methods/import.js
@@ -132,7 +132,7 @@ module.exports = self => {
           .dismiss(req, notificationId, 2000)
           .catch(self.apos.util.error);
 
-        await self.removeExport(exportPath);
+        await self.remove(exportPath);
         return;
       }
 
@@ -531,27 +531,7 @@ module.exports = self => {
         self.apos.notification.dismiss(req, notificationId, 2000).catch(self.apos.util.error);
       }
 
-      await self.removeExport(exportPath);
-    },
-
-    async removeExport(filepath) {
-      try {
-        const stat = await fsp.lstat(filepath);
-        if (stat.isDirectory()) {
-          await fsp.rm(filepath, {
-            recursive: true,
-            force: true
-          });
-        } else {
-          await fsp.unlink(filepath);
-        }
-        console.info(`[import] export path ${filepath} has been removed`);
-      } catch (err) {
-        console.trace();
-        self.apos.util.error(
-          `Error while trying to remove the file or folder: ${filepath}. You might want to remove it yourself.`
-        );
-      }
+      await self.remove(exportPath);
     }
   };
 };
diff --git a/lib/methods/index.js b/lib/methods/index.js
@@ -1,3 +1,4 @@
+const fsp = require('node:fs/promises');
 const importMethods = require('./import');
 const exportMethods = require('./export');
 
@@ -34,6 +35,27 @@ module.exports = self => {
 
       return true;
     },
+
+    async remove(filepath) {
+      try {
+        const stat = await fsp.lstat(filepath);
+        if (stat.isDirectory()) {
+          await fsp.rm(filepath, {
+            recursive: true,
+            force: true
+          });
+        } else {
+          await fsp.unlink(filepath);
+        }
+        console.info(`removed: ${filepath}`);
+      } catch (err) {
+        console.trace();
+        self.apos.util.error(
+          `Error while trying to remove the file or folder: ${filepath}. You might want to remove it yourself.`
+        );
+      }
+    },
+
     ...importMethods(self),
     ...exportMethods(self)
   };