fix sass warnings and lint issues (#84)

* fix sass warnings and lint issues * fix package reference * update changelog --------- Co-authored-by: Harouna Traoré <[email protected]>
apostrophecms · Sep 11, 2024 · 0d4f435 · 0d4f435
1 parent 002d26c
commit 0d4f435
Show file tree

Hide file tree

Showing 6 changed files with 72 additions and 42 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -20,21 +20,21 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18, 20]
+        node-version: [18, 20, 22]
         mongodb-version: ['4.4', '5.0', '6.0']
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
     - name: Git checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
 
     - name: Start MongoDB
-      uses: supercharge/mongodb-github-action@1.8.0
+      uses: supercharge/mongodb-github-action@1.11.0
       with:
         mongodb-version: ${{ matrix.mongodb-version }}
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Changelog
 
+## UNRELEASED
+
+### Fixes
+
+* Fixes SASS warnings.
+
+## Changes
+
+* Update devDependencies.
+
 ## 2.4.0 (2024-09-05)
 
 ### Adds

diff --git a/package.json b/package.json
@@ -42,4 +42,4 @@
     "lodash": "^4.17.21",
     "tar-stream": "^3.1.6"
   }
-}
+}
diff --git a/ui/apos/components/AposDuplicateImportModal.vue b/ui/apos/components/AposDuplicateImportModal.vue
@@ -298,33 +298,39 @@ export default {
 .apos-import-duplicate__heading {
   @include type-title;
 
-  line-height: var(--a-line-tall);
-  margin: 0;
-  text-transform: capitalize;
+  & {
+    line-height: var(--a-line-tall);
+    margin: 0;
+    text-transform: capitalize;
+  }
 }
 
 .apos-import-duplicate__description {
   @include type-base;
 
-  width: calc(100% - 20px);
-  margin-top: 15px;
-  margin-bottom: 20px;
-  padding: 10px;
-  color: var(--a-warning-dark);
-  font-size: var(--a-type-large);
-  text-align: left;
-  line-height: var(--a-line-tallest);
-  background-color: var(--a-warning-fade);
+  & {
+    width: calc(100% - 20px);
+    margin-top: 15px;
+    margin-bottom: 20px;
+    padding: 10px;
+    color: var(--a-warning-dark);
+    font-size: var(--a-type-large);
+    text-align: left;
+    line-height: var(--a-line-tallest);
+    background-color: var(--a-warning-fade);
+  }
 }
 
 .apos-import-duplicate__section {
   @include type-base;
 
-  display: flex;
-  flex-direction: column;
-  align-items: baseline;
-  max-height: 210px;
-  overflow-y: auto;
+  & {
+    display: flex;
+    flex-direction: column;
+    align-items: baseline;
+    max-height: 210px;
+    overflow-y: auto;
+  }
 }
 
 .apos-import-duplicate__section thead {

diff --git a/ui/apos/components/AposExportModal.vue b/ui/apos/components/AposExportModal.vue
@@ -341,27 +341,33 @@ export default {
 .apos-export__heading {
   @include type-title;
 
-  line-height: var(--a-line-tall);
-  margin: 0;
-  text-transform: capitalize;
+  & {
+    line-height: var(--a-line-tall);
+    margin: 0;
+    text-transform: capitalize;
+  }
 }
 
 .apos-export__description {
   @include type-base;
 
-  margin-top: 5px;
-  font-size: var(--a-type-large);
-  text-align: left;
-  line-height: var(--a-line-tallest);
+  & {
+    margin-top: 5px;
+    font-size: var(--a-type-large);
+    text-align: left;
+    line-height: var(--a-line-tallest);
+  }
 }
 
 .apos-export__section {
   @include type-base;
 
-  display: flex;
-  flex-direction: column;
-  align-items: baseline;
-  min-width: 100%;
+  & {
+    display: flex;
+    flex-direction: column;
+    align-items: baseline;
+    min-width: 100%;
+  }
 }
 
 .apos-export__section-container {
@@ -371,9 +377,11 @@ export default {
 .apos-export__settings {
   @include type-base;
 
-  margin-top: 20px;
-  color: var(--a-base-3);
-  font-weight: 600;
+  & {
+    margin-top: 20px;
+    color: var(--a-base-3);
+    font-weight: 600;
+  }
 }
 
 .apos-export__settings-row {

diff --git a/ui/apos/components/AposImportModal.vue b/ui/apos/components/AposImportModal.vue
@@ -184,22 +184,28 @@ export default {
   &__heading {
     @include type-title;
 
-    line-height: var(--a-line-tall);
-    margin: 0;
+    & {
+      line-height: var(--a-line-tall);
+      margin: 0;
+    }
   }
 
   &__warning {
     @include type-small;
 
-    max-width: 348px;
-    padding: 10px;
+    & {
+      max-width: 348px;
+      padding: 10px;
+    }
   }
 
   &__description {
     @include type-base;
 
-    max-width: 370px;
-    line-height: var(--a-line-tallest);
+    & {
+      max-width: 370px;
+      line-height: var(--a-line-tallest);
+    }
   }
 
   &__file {