Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor doc context menu #4266

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Refactor doc context menu #4266

merged 2 commits into from
Aug 14, 2023

Conversation

myovchev
Copy link
Contributor

Summary

Move AposDocContextMenu.vue business logic to a mixin.

As part of HOL-2123.

What are the specific steps to test this change?

No change of the behavior.

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

@myovchev myovchev requested review from ValJed and ETLaurent and removed request for ValJed August 11, 2023 14:50
boutell
boutell previously approved these changes Aug 11, 2023
@myovchev myovchev requested review from boutell and removed request for ETLaurent August 13, 2023 09:16
@prashareet
Copy link

Hello , I am learning Full stack Web development, and currently learning Javascript. I came across your platform while searching for good first issues, and really am new to open source and really want to contribute to your project.

@myovchev myovchev merged commit 51e1579 into main Aug 14, 2023
6 checks passed
@myovchev myovchev deleted the doc-menu-logic branch August 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants