Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot Fix Holon appBuilder bug #4264

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Hot Fix Holon appBuilder bug #4264

merged 2 commits into from
Aug 10, 2023

Conversation

triskuit
Copy link
Contributor

@triskuit triskuit commented Aug 10, 2023 •
edited
Loading

Summary

Fix a downstream bug in the Holon appBuilder when trying to access a property that might not exist PRO-4674

What are the specific steps to test this change?

  1. link this pull in Holon
  2. in holon npm run dev
  3. Navigate to a site
  4. Click appBuilder in nav bar > Add category
  5. The modal loads with content and without errors in the console

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

myovchev
myovchev approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@myovchev myovchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@triskuit triskuit marked this pull request as ready for review August 10, 2023 15:50
@triskuit triskuit merged commit f96ccbf into main Aug 10, 2023
6 checks passed
@triskuit triskuit deleted the hot-fix-holon-appbuilder-bug branch August 10, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myovchev myovchev myovchev approved these changes

@boutell boutell Awaiting requested review from boutell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triskuit @myovchev