Merge pull request #4237 from apostrophecms/pro-4540-save-to-update

fix typo with onSave navigate
apostrophecms · Jul 27, 2023 · 5aabc2c · 5aabc2c
2 parents 5b8ff74 + 641c66c
commit 5aabc2c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,8 @@ to props of their choosing.
 
 ### Fixes
 
+* `AposDocEditor` `onSave` method signature. We now always expect an object when a parameter is passed to the function to check
+the value of `navigate` flag.
 * Fixes a problem in the rich text editor where the slash would not be deleted after item selectin from the insert menu.
 * Modules that have a `public` or `i18n` subdirectory no longer generate a
 warning if they export no code.

diff --git a/modules/@apostrophecms/doc-type/ui/apos/components/AposDocEditor.vue b/modules/@apostrophecms/doc-type/ui/apos/components/AposDocEditor.vue
@@ -519,7 +519,7 @@ export default {
       await this.restore(this.original);
       await this.loadDoc();
     },
-    async onSave(navigate = false) {
+    async onSave({ navigate = false } = {}) {
       if (this.canPublish || !this.manuallyPublished) {
         await this.save({
           andPublish: this.manuallyPublished,