Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-5666: fix /login issues #18

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

PRO-5666: fix /login issues #18

wants to merge 8 commits into from

Conversation

boutell
Copy link
Member

@boutell boutell commented Mar 26, 2024

Fix the following issues with the /login URL:

  • When you first arrived in an incognito window, the first login attempt didn't stick at all, but the second worked. This was due to a failure to cope with multiple Set-Cookie headers in the proxy logic. This was resolved using node-fetch and its support for access to all headers.
  • When you attempted to visit /login while already logged in, you received an error and/or an undesirable page rendered directly by Apostrophe. This was due to the way redirects work in fetch: the full chain of redirects is followed and you are stuck with the end result. This was resolved using node-fetch and its support for manual redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant