Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initial Docker Images #2

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

jonathanrainer
Copy link
Collaborator

@jonathanrainer jonathanrainer commented Aug 20, 2024

In the future we want to be able to standardise on how we build binaries at Apollo, and these Docker Images are a step in that direction. At the moment they exist for glibc and musl Linux builds and may expand in future. These may be used as the source of builder images by other teams or others might use these directly, they are simply a resource to be used/extended.

Further the dependencies here may not be the final set this may need some iteration before we reach the final version of what we want but it's a good starting point.

@jonathanrainer jonathanrainer force-pushed the jr/add-initial-docker-images branch 3 times, most recently from 2c6fbb6 to 0ce4f34 Compare August 21, 2024 12:08
@jonathanrainer jonathanrainer force-pushed the jr/add-initial-docker-images branch 2 times, most recently from 7e62789 to d8dcd73 Compare August 21, 2024 12:41
abernix
abernix previously approved these changes Aug 21, 2024
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only skimmed the changeset here, but not having @abernix be in charge of anything is a good idea, so I approve that removal of him from CODEOWNERS!

# This file was automatically generated by the Apollo SecOps team
# Please customize this file as needed prior to merging.

* @abernix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guy!

loshz
loshz previously approved these changes Aug 21, 2024
@jonathanrainer jonathanrainer dismissed stale reviews from loshz and abernix via ca8ac82 August 29, 2024 07:56
@jonathanrainer jonathanrainer force-pushed the jr/add-initial-docker-images branch 3 times, most recently from cb7608f to 3f25cb7 Compare August 29, 2024 08:20
@jonathanrainer jonathanrainer merged commit 9127891 into main Aug 29, 2024
7 checks passed
@jonathanrainer jonathanrainer deleted the jr/add-initial-docker-images branch August 29, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants