-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode-specific iteration on the ClientNotFoundModal
#1510
Open
phryneas
wants to merge
5
commits into
main
Choose a base branch
from
pr/vscode-connect-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
force-pushed
the
pr/vscode-connect-info
branch
from
September 10, 2024 08:16
f79588c
to
f68639f
Compare
jerelmiller
reviewed
Sep 13, 2024
@@ -101,7 +101,15 @@ export default /** @returns {import("webpack").Configuration} */ (env) => { | |||
chunkFormat: "commonjs", | |||
}, | |||
resolve: { | |||
extensions: [".mjs", ".js", ".ts", ".tsx", ".css"], | |||
extensions: [ | |||
`.${target}.ts`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯 I didnt realize it was this simple. Awesome!
phryneas
force-pushed
the
pr/vscode-connect-info
branch
from
September 20, 2024 12:46
f68639f
to
961a1ae
Compare
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's sure some space for visual improvements but this is a good first pass.