fix: make the Request constructor options typesafe (#2034)

apify · Aug 18, 2023 · 75e7d65 · 75e7d65
1 parent b50ef1a
commit 75e7d65
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/request.ts b/packages/core/src/request.ts
@@ -132,7 +132,7 @@ export class Request<UserData extends Dictionary = Dictionary> {
     /**
      * `Request` parameters including the URL, HTTP method and headers, and others.
      */
-    constructor(options: RequestOptions) {
+    constructor(options: RequestOptions<UserData>) {
         ow(options, 'RequestOptions', ow.object);
         ow(options.url, 'RequestOptions.url', ow.string);
         // 'ow' validation is slow, because it checks all predicates

diff --git a/test/core/storages/request_queue.test.ts b/test/core/storages/request_queue.test.ts
@@ -691,7 +691,7 @@ describe('RequestQueue remote', () => {
         const r2 = new Request({
             url,
             method,
-            userData: {},
+            userData: {} as any,
         });
         const r3 = new Request({
             url,