chore: fix timeouts for waitForSelector in playwright

apify · Jun 6, 2024 · 53ce1d3 · 53ce1d3
1 parent 6f88e73
commit 53ce1d3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/jsdom-crawler/src/internals/jsdom-crawler.ts b/packages/jsdom-crawler/src/internals/jsdom-crawler.ts
@@ -60,7 +60,7 @@ export interface JSDOMCrawlingContext<
     document: Document;
 
     /**
-     * Wait for an element matching the selector to appear. Timeout is ignored.
+     * Wait for an element matching the selector to appear.
      * Timeout defaults to 5s.
      *
      * **Example usage:**

diff --git a/packages/linkedom-crawler/src/internals/linkedom-crawler.ts b/packages/linkedom-crawler/src/internals/linkedom-crawler.ts
@@ -55,7 +55,7 @@ export interface LinkeDOMCrawlingContext<
     document: Document;
 
     /**
-     * Wait for an element matching the selector to appear. Timeout is ignored.
+     * Wait for an element matching the selector to appear.
      * Timeout defaults to 5s.
      *
      * **Example usage:**

diff --git a/packages/playwright-crawler/src/internals/utils/playwright-utils.ts b/packages/playwright-crawler/src/internals/utils/playwright-utils.ts
@@ -827,11 +827,11 @@ export function registerUtilsToContext(
         await injectJQuery(context.page, { surviveNavigations: false });
     };
     context.blockRequests = async (options?: BlockRequestsOptions) => blockRequests(context.page, options);
-    context.waitForSelector = async (selector: string, timeoutMs?: number) => {
+    context.waitForSelector = async (selector: string, timeoutMs = 5_000) => {
         const locator = context.page.locator(selector).first();
         await locator.waitFor({ timeout: timeoutMs, state: 'attached' });
     };
-    context.parseWithCheerio = async (selector?: string, timeoutMs?: number) => {
+    context.parseWithCheerio = async (selector?: string, timeoutMs = 5_000) => {
         if (selector) {
             await context.waitForSelector(selector, timeoutMs);
         }