fix(playwright): allow passing new context options in launchOptions…

… on type level Closes #1849
apify · Jun 11, 2024 · 0519d40 · 0519d40
1 parent c1438b0
commit 0519d40
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/packages/playwright-crawler/src/internals/playwright-launcher.ts b/packages/playwright-crawler/src/internals/playwright-launcher.ts
@@ -26,8 +26,11 @@ import type { Browser, BrowserType, LaunchOptions } from 'playwright';
  * ```
  */
 export interface PlaywrightLaunchContext extends BrowserLaunchContext<LaunchOptions, BrowserType> {
-    /** `browserType.launch` [options](https://playwright.dev/docs/api/class-browsertype#browser-type-launch) */
-    launchOptions?: LaunchOptions;
+    /**
+     * `browserType.launch` [options](https://playwright.dev/docs/api/class-browsertype#browser-type-launch) or
+     * `browserType.launchContextOptions` [options](https://playwright.dev/docs/api/class-browsertype#browser-type-launch-persistent-context)
+     */
+    launchOptions?: LaunchOptions & Parameters<BrowserType['launchPersistentContext']>[1];
 
     /**
      * URL to a HTTP proxy server. It must define the port number,
@@ -84,6 +87,7 @@ export class PlaywrightLauncher extends BrowserLauncher<PlaywrightPlugin> {
     protected static override optionsShape = {
         ...BrowserLauncher.optionsShape,
         launcher: ow.optional.object,
+        launchContextOptions: ow.optional.object,
     };
 
     /**

diff --git a/test/tsconfig.json b/test/tsconfig.json
@@ -10,7 +10,16 @@
 		"module": "Node16",
 		"moduleResolution": "Bundler",
 		"paths": {
-			"@crawlee/utils/src/*": ["packages/utils/src/*"]
+			"crawlee": ["packages/crawlee/src"],
+			"@crawlee/basic": ["packages/basic-crawler/src"],
+			"@crawlee/browser": ["packages/browser-crawler/src"],
+			"@crawlee/http": ["packages/http-crawler/src"],
+			"@crawlee/linkedom": ["packages/linkedom-crawler/src"],
+			"@crawlee/jsdom": ["packages/jsdom-crawler/src"],
+			"@crawlee/cheerio": ["packages/cheerio-crawler/src"],
+			"@crawlee/playwright": ["packages/playwright-crawler/src"],
+			"@crawlee/puppeteer": ["packages/puppeteer-crawler/src"],
+			"@crawlee/*": ["packages/*/src"]
 		}
 	}
 }