Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added get_public_url method to KeyValueStore #567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naaa760
Copy link

@naaa760 naaa760 commented Oct 3, 2024

Description

This pull request introduces the get_public_url method to the KeyValueStore class. This method generates a file URL for a given key, allowing for easy access to stored files. The URL is constructed dynamically based on the storage directory and store name.

Issues

Fix: #514

Testing

  • Unit tests were added to verify the functionality of the get_public_url method. All existing and new tests were executed successfully to ensure no regressions.

Checklist

  • CI passed

@vdusek
Copy link
Collaborator

vdusek commented Oct 3, 2024

Hi @naaa760, you're adding almost 190k new lines of code, are you sure that's correct?

@naaa760
Copy link
Author

naaa760 commented Oct 3, 2024

Hi @naaa760, you're adding almost 190k new lines of code, are you sure that's correct?

I Update the deployment dependencies, that's how it adds up lines of code and yeah it's right!

@belloibrahv
Copy link

The PR title does not conform to the required format. To ensure successful processing, please begin the title with a prefix indicating the type of change (e.g., feat, fix, docs, etc.). For example, you could modify the title to 'feat: Added get_public_url method to KeyValueStore'.

@naaa760 naaa760 changed the title Fix: #514 Added get_public_url method to KeyValueStore Feat: Added get_public_url method to KeyValueStore Oct 3, 2024
@naaa760 naaa760 changed the title Feat: Added get_public_url method to KeyValueStore "Feat: Added get_public_url method to KeyValueStore" Oct 3, 2024
@naaa760 naaa760 changed the title "Feat: Added get_public_url method to KeyValueStore" feat: Added get_public_url method to KeyValueStore Oct 3, 2024
@vdusek
Copy link
Collaborator

vdusek commented Oct 4, 2024

I Update the deployment dependencies, that's how it adds up lines of code and yeah it's right!

Well, certainly your PR should not include your Python environment - the env directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement KeyValueStore.get_public_url
3 participants