Detect errors on missing schema refs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a positive test case and two negative test cases (valid data with invalid schema ref and invalid data with valid schema ref)
joaosa
changed the title
honzajavorek
approved these changes
Mar 2, 2017
src/validators/json-schema.coffee
Outdated
| errorMessages: {} | ||
|
|
||
| for error, index in result?.errors | ||
| for err, index in validationErrors | ||
| # need to create the error in case of missing schema errors |
There was a problem hiding this comment.
I'd be even more verbose with the comment:
# If tv4 meets $ref to a missing schema, it provides
# an "empty" error like this: ['', '': '']There was a problem hiding this comment.
Updated the comment :)
Reformat tv4's missing schema output to match the expected validation error format
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info here