Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date cues #265

Merged
merged 1 commit into from
Jul 17, 2024
Merged

date cues #265

merged 1 commit into from
Jul 17, 2024

Conversation

cvinot
Copy link
Contributor

@cvinot cvinot commented Feb 22, 2024

Suggestion of date cues as mentioned in #253

  • Allows users to parse their own date format if desired
  • Allows transparency on properties of dates assigned

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.94%. Comparing base (084aa4f) to head (86383ef).
Report is 52 commits behind head on master.

❗ Current head 86383ef differs from pull request most recent head 08f45d5. Consider uploading reports for the commit 08f45d5 to get more accurate results

Files Patch % Lines
edsnlp/pipes/misc/dates/dates.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   96.95%   96.94%   -0.02%     
==========================================
  Files         255      255              
  Lines        8591     8595       +4     
==========================================
+ Hits         8329     8332       +3     
- Misses        262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw
Copy link
Member

Thanks ! We'll try to review this asap

@cvinot
Copy link
Contributor Author

cvinot commented Jul 17, 2024

Hey @percevalw any chance to see this merged in a short term future ? It isn't much, I basicaly just repeated the cues you already had in negations/hypothesis in dates.

Sorry If the test don't pass I don't really see the link with the related modifications.

Copy link
Member

@percevalw percevalw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cvinot, I'm really sorry for the delay, I'd completely forgotten. Your PR is perfectly fine, and the error was completely unrelated to your changes. I'll merge it shortly

@percevalw percevalw force-pushed the date-cues branch 4 times, most recently from 46c80c5 to 78699df Compare July 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants