-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse ASSUME declarations names #2808
Conversation
tla-io/src/main/scala/at/forsyte/apalache/io/json/TlaToJson.scala
Outdated
Show resolved
Hide resolved
tla-io/src/test/scala/at/forsyte/apalache/io/TestPrettyWriterWithTypes.scala
Outdated
Show resolved
Hide resolved
tla-typechecker/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/ToEtcExpr.scala
Outdated
Show resolved
Hide resolved
@@ -348,7 +348,7 @@ trait IrGenerators extends TlaType1Gen { | |||
for { | |||
ex <- exGen | |||
tt <- genTypeTag | |||
} yield TlaAssumeDecl(ex).withTag(tt) | |||
} yield TlaAssumeDecl(None, ex).withTag(tt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we generate named version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, let's not worry about it for now. We can allow add that in a follow up. The generators are do for an overhaul at some point any how.
6e469bd
to
ae236cd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
==========================================
+ Coverage 78.82% 78.90% +0.08%
==========================================
Files 467 467
Lines 15932 15942 +10
Branches 2588 2589 +1
==========================================
+ Hits 12558 12579 +21
+ Misses 3374 3363 -11 ☔ View full report in Codecov by Sentry. |
ae236cd
to
e8c3b16
Compare
I added additional tests to increase code coverage based on the Codecov report, but these tests look ad-hoc, @shonfeder please advise whether I should preserve them or replace with something else, or just drop and ignore Codecov warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! It was a pleasure to review. Thanks so much for picking this up :)
I have a few small change requests, and a suggestion or two, but they are all minor nits.
tla-io/src/main/scala/at/forsyte/apalache/io/json/TlaToJson.scala
Outdated
Show resolved
Hide resolved
tla-io/src/main/scala/at/forsyte/apalache/io/quint/QuintIR.scala
Outdated
Show resolved
Hide resolved
tla-io/src/main/scala/at/forsyte/apalache/tla/imp/AssumeTranslator.scala
Outdated
Show resolved
Hide resolved
tla-io/src/test/scala/at/forsyte/apalache/io/TestPrettyWriterWithTypes.scala
Outdated
Show resolved
Hide resolved
tla-io/src/test/scala/at/forsyte/apalache/io/TestPrettyWriterWithTypes.scala
Outdated
Show resolved
Hide resolved
tla-typechecker/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/ToEtcExpr.scala
Outdated
Show resolved
Hide resolved
tla-typechecker/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/ToEtcExpr.scala
Show resolved
Hide resolved
tla-typechecker/src/test/scala/at/forsyte/apalache/tla/typecheck/etc/TestToEtcExprDecls.scala
Outdated
Show resolved
Hide resolved
I think the tests look OK :) In the future, if you don't think a test is meaningful, no need to add it just to get the coverage metrics, but since they are already here, let's keep 'em. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Closes #1835
make fmt-fix
(or had formatting run automatically on all files edited)./unreleased/
for any new functionality