Revise the ITF format #2733
Merged
Revise the ITF format #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2733 +/- ##
==========================================
+ Coverage 78.52% 78.53% +0.01%
==========================================
Files 463 463
Lines 15904 15900 -4
Branches 2563 2539 -24
==========================================
- Hits 12488 12487 -1
+ Misses 3416 3413 -3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2732. In this PR, we further simplify the ITF format by always representing integers as
{ "#bigint": "num" }, instead of having two cases, namely,numfor small integers and{ "#bigint": "num" }for big integers. This should simplify the usage of ITF in tests.