MockOracle refactor #2731
Merged
MockOracle refactor #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
==========================================
- Coverage 78.86% 78.84% -0.02%
==========================================
Files 466 467 +1
Lines 15923 15930 +7
Branches 2557 2553 -4
==========================================
+ Hits 12557 12560 +3
- Misses 3366 3370 +4 ☔ View full report in Codecov by Sentry. |
4 tasks
thpani
approved these changes
Oct 20, 2023
Comment on lines
129
to
130
| // Ignored until we figure out why it's killing GH CLI | ||
| ignore("getIndexOfChosenValueFromModel recovers the index correctly") { |
There was a problem hiding this comment.
Can we
- refer to the relevant issue here, and
- leave a note under that issue to (re-)enable these tests?
| check(prop, minSuccessful(1000), sizeRange(4)) | ||
| } | ||
|
|
||
| // We don't actually need the solver in MockOracle |
There was a problem hiding this comment.
By this you mean, we are passing it, but it's not actually invoked?
Comment on lines
73
to
74
| // Ignored until we figure out why it's killing GH CLI | ||
| ignore("getIndexOfChosenValueFromModel recovers the index correctly") { |
There was a problem hiding this comment.
Can we
- refer to the relevant issue here, and
- leave a note under that issue to (re-)enable these tests?
|
Looks like the CI failures were just transient issues in the GH runners. I'll fix the comments and get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionalityFollowing the pattern laid out in #2709 for
IntOracle, this PR introduces the same alterations toMockOracle.