-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYSTEMDS-3172] Sparse CSC Block #2132
Conversation
…y indexRnage methods still missing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
============================================
- Coverage 71.14% 71.02% -0.12%
- Complexity 43048 43173 +125
============================================
Files 1446 1447 +1
Lines 164246 164978 +732
Branches 32018 32170 +152
============================================
+ Hits 116847 117179 +332
- Misses 38249 38621 +372
- Partials 9150 9178 +28 ☔ View full report in Codecov by Sentry. |
LGTM - thanks for the additional sparse block @ReneEnjilian. During the merge I fixed remaining warnings, and removed the wildcard imports. Furthermore, some operations are really slow (the sparse component tests now run 300+ seconds) - accordingly, I will do a few runtime improvements in order to reduce this test runtime. |
This PR is just a supplement to a previous task and implements the Sparse CSC Block. MCSC and CSC will most likely only be used for some experiments (@Baunsgaard ) and there will not be a deeper integration for now. Other systems such as PyTorch support both row and column oriented matrix compression formats and now SystemDS does too. I implemented both the row and the column APIs. Further, testing has been added.