fix: Reordering echart props to fix confidence interval in Mixed Charts

[geotab-data-platform]

fix(echarts): confidence interval does not display correctly for mixed time series charts with negative values

SUMMARY

The root cause of this problem lies within the order of the arguments sent to the echarts library. When working with time-series data, Echarts enforces specific constraints on how the x-axis bounds are configured. These constraints include:
In other words, the Echarts Library accepts input in this specific format and will malfunction otherwise. Superset does not create the Echarts modal with the options in this order.

• The xaxis.type option must be explicitly set to 'time'.
• The upper and lower bound values must be equal to the lower bound.
• The upper bound must be defined before the lower bound in the options object.

Currently, the code in Superset that generates the Echarts configuration does not adhere to this required format, leading to the observed malfunction. This pull request rectifies this issue by reordering the upper and lower bound arguments before they are passed to the Echarts library.

What is currently being sent

What should actually be sent

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

create a mixed chart on the explore menu using confidence intervals where the names__yhat_lower bound is negative at least once.

Verify that confidence Intervals behave as Intended.

names__yhat: trend/point estimate
names__yhat_lower: lower confidence level
names__yhat_upper: upper confidence level

ADDITIONAL INFORMATION

Fixes #30554

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

@geotab-data-platform I don't see this PR changing enforcing or updating the xaxis.type = 'time' issue, despite it being changed in the "after" example. Is this not changed here?

[vedantprajapati17]

xaxis type defaults to "value" if not reordered and there are negative bound values. When its ordered properly, it uses "time".