-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep #30069
Conversation
…ng JSDOM dep Signed-off-by: hainenber <[email protected]>
…d in newly generated Viz plugin Signed-off-by: hainenber <[email protected]>
Thanks for fixing this @hainenber ! @rusackas do you have time to validate this? If not I can try to carve out some time for it next week.. |
@villebro sadly it's not likely... I have a couple days PTO, and other things cooking. Thank you @hainenber for continuing to help us with this. As always, we're appreciating your help around here immensely. For anyone who's interested, I'm thinking it might be time to step away from the generator. My two cents is that we really just need a sample plugin in the repo, which would be testable in CI/Storybook, but not actually instantiated in Superset. Then whenever we bump packages, change components, mess with controls, we'll know more about what we're breaking, and The "how to build a plugin" tutorial would basically be "copy the directory, and change these files:" This is obviously SIP stuff... but I'm dropping it here anyway... because it's Friday :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on the diff. I haven't had time to run it yet, but don't want to block it.
I have no idea why E2E tests are failing though. Seems to be a bit flaky these days, judging from recent commits in |
Closing and reopening to kick CI. A lot of the CI issues have been fixed, so a rebase might help if we can't get this to pass in a couple of retries. |
fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep
SUMMARY
Fixes #29995
Fixes #30297
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER
TESTING INSTRUCTIONS
Follow instructions in
howtos.mdx
inCreating a simple Hello World viz plugin
section and confirms thatnpm run build
is successfulADDITIONAL INFORMATION