fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep

[hainenber]

fix(frontend/generator): fix failed Viz plugin build due to missing JSDOM config and dep

SUMMARY

Fixes #29995
Fixes #30297

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER

TESTING INSTRUCTIONS

Follow instructions in howtos.mdx in Creating a simple Hello World viz plugin section and confirms that npm run build is successful

ADDITIONAL INFORMATION

• Has associated issue: 29995
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

Thanks for fixing this @hainenber ! @rusackas do you have time to validate this? If not I can try to carve out some time for it next week..

[rusackas]

@villebro sadly it's not likely... I have a couple days PTO, and other things cooking.

Thank you @hainenber for continuing to help us with this. As always, we're appreciating your help around here immensely.

For anyone who's interested, I'm thinking it might be time to step away from the generator. My two cents is that we really just need a sample plugin in the repo, which would be testable in CI/Storybook, but not actually instantiated in Superset. Then whenever we bump packages, change components, mess with controls, we'll know more about what we're breaking, and The "how to build a plugin" tutorial would basically be "copy the directory, and change these files:" This is obviously SIP stuff... but I'm dropping it here anyway... because it's Friday :P

[rusackas]

LGTM based on the diff. I haven't had time to run it yet, but don't want to block it.

[hainenber]

I have no idea why E2E tests are failing though. Seems to be a bit flaky these days, judging from recent commits in master branch :D

[rusackas]

Closing and reopening to kick CI. A lot of the CI issues have been fixed, so a rebase might help if we can't get this to pass in a couple of retries.