-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(dev-deps, deps): upgrade major versions for FE deps #29963
build(dev-deps, deps): upgrade major versions for FE deps #29963
Conversation
…est refactor Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…e extraneous eslint process during build Signed-off-by: hainenber <[email protected]>
…SM import Also bumps fast-glob and fs-extra to remove some extra sub-packages Signed-off-by: hainenber <[email protected]>
…ow-up refactors Signed-off-by: hainenber <[email protected]>
…toolkit alternative Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…ully compatible yet Signed-off-by: hainenber <[email protected]>
Awesome, thanks! I'll test locally (especially the docs) right now :) |
Interestingly, for the documentation, if I do "yarn serve" it runs just fine, but if I do "yarn build" it crashes on me. |
@hainenber you were right, Node 20 does the trick. I've made (and merged) a PR to bump all of Superset to Node 20, so it's official now: we're there! I'm approving the PR, but it looks like it needs a rebase, then we should be good to go! Thanks again for this... it's awesome. |
…nd-deps Signed-off-by: hainenber <[email protected]>
I've rebased and pending for green checks now :D I've got a failed |
…ng JSDOM dep Signed-off-by: hainenber <[email protected]>
…d in newly generated Viz plugin Signed-off-by: hainenber <[email protected]>
…nd-deps Signed-off-by: hainenber <[email protected]>
Merged! Thanks again for the help with this! |
Hi I think this merge broke embedded-sdk for Node 18. My app broke exactly when this was pushed and I did not change anything about my superset components. Can we roll it back please I am on a tight schedule and can't work around this with explicit imports due to the way the package.json is configured for embedded-sdk
my package.json:
Thanks! |
I thoroughly checked the changes introduced by this commit and found them unrelated to |
build(dev-deps, deps): upgrade major versions for FE deps
Closes #29817, #29950, #29761, #29757, #29741, #29704
SUMMARY
Aggregation of changes required for bumping major versions for several FE dependencies, notably
@emotion/react
(v11.4.0 -> 11.3.0)immer
(v9 -> v10)fork-ts-checker-webpack-plugin
(v6 -> v9)eslint
against codebase and since CI already includeseslint
step, I've removed it from Webpack config. Lmk if this is OK to go forwardantd
(v4 -> v5)cross-env
(v5 -> v7)echarts
(v5.4 -> v5.5)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION