fix: load slack channels earlier #29846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Loading slack channels earlier to ensure that the method dropdowns have the correct value when they are loaded. Instead of loading slack channels when the slack option is selected, I am now loading the options when the notification method is rendered. That way, we know if we need to use slack v1 or v2 by the time the notification method options are rendered (since we filter out one of the options, so that only one slack option displays)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
no visual changes
TESTING INSTRUCTIONS
If the feature flag is on, but the scopes are missing, a v1 (textarea input field) should display for slack.
ADDITIONAL INFORMATION