chore: Add downloadAsImage types, change filter selector (#26297)

apache · Dec 21, 2023 · 5e85f5c · 5e85f5c
1 parent 60abf7e
commit 5e85f5c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 26 deletions.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -252,6 +252,7 @@
     "@testing-library/react-hooks": "^5.0.3",
     "@testing-library/user-event": "^12.7.0",
     "@types/classnames": "^2.2.10",
+    "@types/dom-to-image": "^2.6.7",
     "@types/enzyme": "^3.10.5",
     "@types/enzyme-adapter-react-16": "^1.0.6",
     "@types/fetch-mock": "^7.3.2",

diff --git a/superset-frontend/src/types/dom-to-image-more.d.ts b/superset-frontend/src/types/dom-to-image-more.d.ts
@@ -18,20 +18,6 @@
  */
 
 declare module 'dom-to-image-more' {
-  export interface Options {
-    filter?: ((node: Node) => boolean) | undefined;
-    bgcolor?: string | undefined;
-    width?: number | undefined;
-    height?: number | undefined;
-    style?: {} | undefined;
-    quality?: number | undefined;
-    imagePlaceholder?: string | undefined;
-    cacheBust?: boolean | undefined;
-  }
-
-  class DomToImageMore {
-    static toJpeg(node: Node, options?: Options): Promise<string>;
-  }
-
-  export default DomToImageMore;
+  import domToImage = require('dom-to-image-more');
+  export = domToImage;
 }
diff --git a/superset-frontend/src/utils/downloadAsImage.ts b/superset-frontend/src/utils/downloadAsImage.ts
@@ -62,25 +62,24 @@ export default function downloadAsImage(
       if (typeof node.className === 'string') {
         return (
           node.className !== 'mapboxgl-control-container' &&
-          !node.className.includes('ant-dropdown')
+          !node.className.includes('header-controls')
         );
       }
       return true;
     };
 
     return domToImage
       .toJpeg(elementToPrint, {
-        quality: 1,
         bgcolor: supersetTheme.colors.grayscale.light4,
         filter,
       })
-      .then(dataUrl => {
+      .then((dataUrl: string) => {
         const link = document.createElement('a');
         link.download = `${generateFileStem(description)}.jpg`;
         link.href = dataUrl;
         link.click();
       })
-      .catch(e => {
+      .catch((e: Error) => {
         console.error('Creating image failed', e);
       });
   };