Skip to content

Commit

Permalink
fix: KeyError 'sql' when opening a Trino virtual dataset (#30339)
Browse files Browse the repository at this point in the history
(cherry picked from commit ef9e5e5)
  • Loading branch information
michael-s-molina authored and sadpandajoe committed Sep 19, 2024
1 parent 2561b26 commit 072540f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions superset/commands/sql_lab/execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
# pylint: disable=too-few-public-methods, too-many-arguments
from __future__ import annotations

import copy
import logging
from typing import Any, TYPE_CHECKING

Expand Down Expand Up @@ -152,8 +151,6 @@ def _run_sql_json_exec_from_scratch(self) -> SqlJsonExecutionStatus:
self._validate_access(query)
self._execution_context.set_query(query)
rendered_query = self._sql_query_render.render(self._execution_context)
validate_rendered_query = copy.copy(query)
validate_rendered_query.sql = rendered_query
self._set_query_limit_if_required(rendered_query)
self._query_dao.update(
query, {"limit": self._execution_context.query.limit}
Expand Down
2 changes: 0 additions & 2 deletions superset/sqllab/sql_json_executer.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def execute(
rendered_query: str,
log_params: dict[str, Any] | None,
) -> SqlJsonExecutionStatus:
print(">>> execute <<<")
query_id = execution_context.query.id
try:
data = self._get_sql_results_with_timeout(
Expand All @@ -102,7 +101,6 @@ def execute(
raise
except Exception as ex:
logger.exception("Query %i failed unexpectedly", query_id)
print(str(ex))
raise SupersetGenericDBErrorException(
utils.error_msg_from_exception(ex)
) from ex
Expand Down

0 comments on commit 072540f

Please sign in to comment.