WW-3714 Deprecate and repackage common APIs part 2.5 #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
kusal-depr-apis-3.5
branch
from
b3d72a2
to
36a890b
Compare
…wareResult marker interfaces respected
|
|
@lukaszlenart Sorry to bug you but I need this one reviewed and merged first (as the other PRs are stacked on top) 🙂 |
lukaszlenart
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-3714
Ensure factory support for new Interceptor, Result interfaces introduced in #1079.
When Results and Interfaces are parsed and instantiated from XML configuration they are expected to be of the deprecated
com.opensymphony.xwork2types. We want to also ensure the neworg.apache.struts2types are supported. We cannot easily change the factory interface signatures without breaking compatibility for the associated extension points. Thus, we ensure these types are adapted within the default factory implementations instead. Additional helper code was needed to ensure that the marker interfacesReflectionExceptionHandler,WithLazyParams,ParamNameAwareResultare still respected. This helper code can of course be completely discarded in Struts 7.0.