[SPARK-49927][SS] pyspark.sql.tests.streaming.test_streaming_listener to wait longer #48414
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WweiL
approved these changes
Oct 10, 2024
HyukjinKwon
previously approved these changes
Oct 11, 2024
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Oct 11, 2024
…chId` to `q.lastProgress.progress.batchId` ### What changes were proposed in this pull request? This PR is a followup of #48414 that fixes `q.lastProgress.batchId` -> `q.lastProgress.progress.batchId` to fix the test. ### Why are the changes needed? `q.lastProgress` does not have `progress`. We should fix it to fix up the broken build. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48419 from HyukjinKwon/SPARK-49927-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
Build was broken so I reverted it. |
brkyvz
reviewed
Oct 11, 2024
| @@ -381,7 +381,8 @@ def verify(test_listener): | |||
| .start() | |||
| ) | |||
| self.assertTrue(q.isActive) | |||
| q.awaitTermination(10) | |||
| while progress_event is None or progress_event.batchId == 0: | |||
There was a problem hiding this comment.
do we not want to add a timeout that could be longer? Maybe 60 seconds or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In test pyspark.sql.tests.streaming.test_streaming_listener, instead of waiting for fixed 10 seconds, we wait for progress made.
Why are the changes needed?
In some environment, the test fails with progress_event appears to be None. Likely the wait time is not sufficient.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run the patch and make sure it still passes
Was this patch authored or co-authored using generative AI tooling?
No