feat: support ranges for Value Mappings #421
Conversation
src/views/dashboard/graphs/Card.vue
Outdated
| withinRange = k.startsWith("(-∞") || Number(singleVal.value) > ranges[0]; | ||
| } | ||
| if (k.endsWith("]")) { | ||
| withinRange = withinRange && (k.endsWith("+∞]") || Number(singleVal.value) <= (ranges[1] || ranges[0])); |
There was a problem hiding this comment.
So, +∞ and -∞ are supported if we need no upper or lower boundary?
There was a problem hiding this comment.
I have a little concern of ∞, it is hard to input from the keyboard. How about infinite+ and infinite-
There was a problem hiding this comment.
If this supports writing regular expressions directly, how about that. For example, ^(10|[0-9])$ matches 0-10.
There was a problem hiding this comment.
How to write 25-34 in regex? Regex is better in string pattern match I think.
There was a problem hiding this comment.
\b(2[5-9]|3[0-4])\b could catch up, regex may not be as intuitive as the current method.
There was a problem hiding this comment.
@Fine0830 Could you try to change the format to include a regex?
Could you we add tips about how to setup the range? The contributors/users will not be able to watch this video and learn how to use this. We need to way to guide them. Or If you want to put this in the documents, you should update this doc. https://skywalking.apache.org/docs/main/next/en/ui/readme/ |
|
fyi @CodePrometheus |
|
@CodePrometheus I think we need to update your dashboard to adopt this change. Could you do that soon? I could merge this when you are ready to follow. FYI, the config key is changed, so you need to remove the old one and add the new config. |
Let me sync ui later, thanks @Fine0830 |
Related apache/skywalking#12696 (comment)
Video
1.mov
Signed-off-by: Qiuxia Fan [email protected]