Skip to content

Commit

Permalink
Fix compile errors in golang opcua driver.
Browse files Browse the repository at this point in the history
Signed-off-by: Łukasz Dywicki <[email protected]>
  • Loading branch information
splatch committed Aug 20, 2024
1 parent d3f0ab5 commit f4d9c83
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 25 deletions.
3 changes: 1 addition & 2 deletions plc4go/internal/opcua/Reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,9 @@ func (m *Reader) readSync(ctx context.Context, readRequest apiModel.PlcReadReque
requestHeader,
0.0,
readWriteModel.TimestampsToReturn_timestampsToReturnNeither,
int32(len(readValueArray)),
readValueArray)

identifier, err := strconv.ParseUint(opcuaReadRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(opcuaReadRequest.GetExtensionId(), 10, 16)
if err != nil {
result <- spiModel.NewDefaultPlcReadRequestResult(readRequest, nil, errors.Wrapf(err, "error parsing identifier"))
return
Expand Down
22 changes: 8 additions & 14 deletions plc4go/internal/opcua/SecureChannel.go
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ func (s *SecureChannel) onConnectOpenSecureChannel(ctx context.Context, connecti
s.lifetime)
}

identifier, err := strconv.ParseUint(openSecureChannelRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(openSecureChannelRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
connection.fireConnectionError(err, ch)
Expand Down Expand Up @@ -504,7 +504,6 @@ func (s *SecureChannel) onConnectCreateSessionRequest(ctx context.Context, conne
readWriteModel.NewPascalString("en"),
APPLICATION_TEXT)

noOfDiscoveryUrls := int32(-1)
var discoveryUrls []readWriteModel.PascalString

clientDescription := readWriteModel.NewApplicationDescription(APPLICATION_URI,
Expand All @@ -513,7 +512,6 @@ func (s *SecureChannel) onConnectCreateSessionRequest(ctx context.Context, conne
readWriteModel.ApplicationType_applicationTypeClient,
NULL_STRING,
NULL_STRING,
noOfDiscoveryUrls,
discoveryUrls)

createSessionRequest := readWriteModel.NewCreateSessionRequest(
Expand All @@ -528,7 +526,7 @@ func (s *SecureChannel) onConnectCreateSessionRequest(ctx context.Context, conne
0,
)

identifier, err := strconv.ParseUint(createSessionRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(createSessionRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
connection.fireConnectionError(err, ch)
Expand Down Expand Up @@ -643,15 +641,13 @@ func (s *SecureChannel) onConnectActivateSessionRequest(ctx context.Context, con
activateSessionRequest := readWriteModel.NewActivateSessionRequest(
requestHeader,
clientSignature,
0,
nil,
0,
nil,
userIdentityToken,
clientSignature,
)

identifier, err := strconv.ParseUint(activateSessionRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(activateSessionRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
connection.fireConnectionError(err, ch)
Expand Down Expand Up @@ -831,7 +827,7 @@ func (s *SecureChannel) onDisconnectCloseSecureChannel(ctx context.Context, conn

closeSecureChannelRequest := readWriteModel.NewCloseSecureChannelRequest(requestHeader)

identifier, err := strconv.ParseUint(closeSecureChannelRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(closeSecureChannelRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
return
Expand Down Expand Up @@ -982,7 +978,7 @@ func (s *SecureChannel) onDiscoverOpenSecureChannel(ctx context.Context, codec *
s.lifetime,
)

identifier, err := strconv.ParseUint(openSecureChannelRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(openSecureChannelRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
return
Expand Down Expand Up @@ -1110,12 +1106,10 @@ func (s *SecureChannel) onDiscoverGetEndpointsRequest(ctx context.Context, codec
endpointsRequest := readWriteModel.NewGetEndpointsRequest(
requestHeader,
s.endpoint,
0,
nil,
0,
nil)

identifier, err := strconv.ParseUint(endpointsRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(endpointsRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
return
Expand Down Expand Up @@ -1239,7 +1233,7 @@ func (s *SecureChannel) onDiscoverCloseSecureChannel(ctx context.Context, codec

closeSecureChannelRequest := readWriteModel.NewCloseSecureChannelRequest(requestHeader)

identifier, err := strconv.ParseUint(closeSecureChannelRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(closeSecureChannelRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Debug().Err(err).Msg("error parsing identifier")
return
Expand Down Expand Up @@ -1361,7 +1355,7 @@ func (s *SecureChannel) keepAlive() {
NULL_BYTE_STRING,
uint32(s.lifetime))
}
identifier, err := strconv.ParseUint(openSecureChannelRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(openSecureChannelRequest.GetExtensionId(), 10, 16)
if err != nil {
s.log.Error().Err(err).Msg("error parsing identifier")
return
Expand Down
2 changes: 1 addition & 1 deletion plc4go/internal/opcua/Subscriber.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (s *Subscriber) onSubscribeCreateSubscription(ctx context.Context, cycleTim
0,
)

identifier, err := strconv.ParseUint(createSubscriptionRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(createSubscriptionRequest.GetExtensionId(), 10, 16)
if err != nil {
return nil, errors.Wrapf(err, "error parsing identifier")
}
Expand Down
9 changes: 3 additions & 6 deletions plc4go/internal/opcua/SubscriptionHandle.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,10 @@ func (h *SubscriptionHandle) onSubscribeCreateMonitoredItemsRequest() (readWrite
requestHeader,
h.subscriptionId,
readWriteModel.TimestampsToReturn_timestampsToReturnBoth,
int32(len(requestList)),
requestList,
)

identifier, err := strconv.ParseUint(createMonitoredItemsRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(createMonitoredItemsRequest.GetExtensionId(), 10, 16)
if err != nil {
return nil, errors.Wrapf(err, "error parsing identifier")
}
Expand Down Expand Up @@ -269,11 +268,10 @@ func (h *SubscriptionHandle) startSubscriber() {

publishRequest := readWriteModel.NewPublishRequest(
requestHeader,
int32(ackLength),
acks,
)

identifier, err := strconv.ParseUint(publishRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(publishRequest.GetExtensionId(), 10, 16)
if err != nil {
h.log.Error().Err(err).Msg("error parsing identifier")
continue
Expand Down Expand Up @@ -384,11 +382,10 @@ func (h *SubscriptionHandle) stopSubscriber() {

subscriptions := []uint32{h.subscriptionId}
deleteSubscriptionrequest := readWriteModel.NewDeleteSubscriptionsRequest(requestHeader,
1,
subscriptions,
)

identifier, err := strconv.ParseUint(deleteSubscriptionrequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(deleteSubscriptionrequest.GetExtensionId(), 10, 16)
if err != nil {
h.log.Error().Err(err).Msg("error parsing identifier")
return
Expand Down
3 changes: 1 addition & 2 deletions plc4go/internal/opcua/Writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,10 @@ func (m *Writer) WriteSync(ctx context.Context, writeRequest apiModel.PlcWriteRe

opcuaWriteRequest := readWriteModel.NewWriteRequest(
requestHeader,
int32(len(writeValueArray)),
writeValueArray,
)

identifier, err := strconv.ParseUint(opcuaWriteRequest.GetIdentifier(), 10, 16)
identifier, err := strconv.ParseUint(opcuaWriteRequest.GetExtensionId(), 10, 16)
if err != nil {
result <- spiModel.NewDefaultPlcWriteRequestResult(writeRequest, nil, errors.Wrapf(err, "error parsing identifier"))
return
Expand Down

0 comments on commit f4d9c83

Please sign in to comment.