feat(plc4j)!: Improve stability of code through stricter compiler che…

…cks of generated contents. BREAKING CHANGE: Removed `staticParse(io, ... args)` methods. Signed-off-by: Łukasz Dywicki <[email protected]>
apache · Aug 23, 2024 · 5a2e560 · 5a2e560
1 parent b6226d6
commit 5a2e560
Show file tree

Hide file tree

Showing 32 changed files with 159 additions and 194 deletions.
diff --git a/...eneration/language-java/src/main/resources/templates/java/complex-type-template.java.ftlh b/...eneration/language-java/src/main/resources/templates/java/complex-type-template.java.ftlh
@@ -580,32 +580,6 @@ public<#if type.isDiscriminatedParentTypeDefinition()> abstract</#if> class ${ty
         return lengthInBits;
     }
 
-<#-- The parse and serialize methods here are just proxies for forwardning the requests to static counterparts -->
-    <#if !type.isDiscriminatedChildTypeDefinition()>
-    public static ${type.name} staticParse(ReadBuffer readBuffer, Object... args) throws ParseException {
-        PositionAware positionAware = readBuffer;
-        <#if parserArguments?has_content>
-        if((args == null) || (args.length != ${parserArguments?size})) {
-            throw new PlcRuntimeException("Wrong number of arguments, expected ${parserArguments?size}, but got " + args.length);
-        }
-            <#list parserArguments as parserArgument>
-                <#assign languageName=helper.getLanguageTypeNameForTypeReference(parserArgument.type, false)>
-        ${languageName} ${parserArgument.name};
-        if(args[${parserArgument?index}] instanceof ${languageName}) {
-            ${parserArgument.name} = (${languageName}) args[${parserArgument?index}];
-                <#if parserArgument.type.isSimpleTypeReference() || parserArgument.type.isEnumTypeReference()>
-        } else if (args[${parserArgument?index}] instanceof String) {
-            ${parserArgument.name} = ${languageName}.valueOf((String) args[${parserArgument?index}]);
-                </#if>
-        } else {
-            throw new PlcRuntimeException("Argument ${parserArgument?index} expected to be of type ${languageName} or a string which is parseable but was " + args[${parserArgument?index}].getClass().getName());
-        }
-            </#list>
-        </#if>
-        return staticParse(readBuffer<#if parserArguments?has_content>, <#list parserArguments as parserArgument>${parserArgument.name}<#sep>, </#sep></#list></#if>);
-    }
-
-    </#if>
 <#-- Here come the actual parse and serialize methods that actually do the parsing and serlaizing -->
     <#assign hasParserArguments=parserArguments?has_content/>
     <#assign parserArgumentList><#if hasParserArguments><#list parserArguments as parserArgument>${helper.getLanguageTypeNameForTypeReference(parserArgument.type, false)} ${parserArgument.name}<#sep>, </#sep></#list></#if></#assign>

diff --git a/plc4j/drivers/c-bus/src/main/java/org/apache/plc4x/java/cbus/CBusDriver.java b/plc4j/drivers/c-bus/src/main/java/org/apache/plc4x/java/cbus/CBusDriver.java
@@ -19,6 +19,9 @@
 package org.apache.plc4x.java.cbus;
 
 import io.netty.buffer.ByteBuf;
+import org.apache.plc4x.java.cbus.readwrite.CBusMessage;
+import org.apache.plc4x.java.cbus.readwrite.CBusOptions;
+import org.apache.plc4x.java.cbus.readwrite.RequestContext;
 import org.apache.plc4x.java.spi.configuration.PlcConnectionConfiguration;
 import org.apache.plc4x.java.spi.configuration.PlcTransportConfiguration;
 import org.apache.plc4x.java.api.value.PlcValueHandler;
@@ -92,7 +95,8 @@ protected PlcValueHandler getValueHandler() {
 
     @Override
     protected ProtocolStackConfigurer<CBusCommand> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(CBusCommand.class, CBusCommand::staticParse)
+        return SingleProtocolStackConfigurer.builder(CBusCommand.class, io ->
+                CBusCommand.staticParse(io, new CBusOptions(false, false, false, false, false, false, false, false, false)))
             .withProtocol(CBusProtocolLogic.class)
             .withDriverContext(CBusDriverContext.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)

diff --git a/...anopen/src/main/java/org/apache/plc4x/java/canopen/transport/CANOpenFrameDataHandler.java b/...anopen/src/main/java/org/apache/plc4x/java/canopen/transport/CANOpenFrameDataHandler.java
@@ -48,7 +48,7 @@ public CANOpenFrameDataHandler(Supplier<CANFrameBuilder<Message>> builder) {
     public CANOpenFrame fromCAN(FrameData frame) {
         CANOpenService service = StaticHelper.serviceId((short) frame.getNodeId());
         int nodeId = Math.abs(service.getMin() - frame.getNodeId());
-        return new CANOpenFrame((short) nodeId, service, frame.read(CANOpenPayload::staticParse, service));
+        return new CANOpenFrame((short) nodeId, service, frame.read(io -> CANOpenPayload.staticParse(io, service)));
     }
 
     @Override

diff --git a/...anopen/src/test/java/org/apache/plc4x/java/canopen/transport/CANOpenFrameDataAdapter.java b/...anopen/src/test/java/org/apache/plc4x/java/canopen/transport/CANOpenFrameDataAdapter.java
@@ -43,7 +43,7 @@ public int getNodeId() {
             }
 
             @Override
-            public <T extends Message> T read(MessageInput<T> input, Object... args) {
+            public <T extends Message> T read(MessageInput<T> input) {
                 return (T) frame.getPayload();
             }
 

diff --git a/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/base/EIPDriver.java b/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/base/EIPDriver.java
@@ -120,10 +120,9 @@ protected boolean canWrite() {
 
     @Override
     protected ProtocolStackConfigurer<EipPacket> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(EipPacket.class, EipPacket::staticParse)
+        return SingleProtocolStackConfigurer.builder(EipPacket.class, io -> EipPacket.staticParse(io, true))
             .withProtocol(EipProtocolLogic.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)
-            .withParserArgs(true)
             .withCorruptPacketRemover(CorruptPackageCleaner.class)
             .byteOrder(this.configuration.getByteOrder())
             .build();

diff --git a/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/logix/LogixDriver.java b/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/logix/LogixDriver.java
@@ -99,10 +99,9 @@ protected boolean canWrite() {
 
     @Override
     protected ProtocolStackConfigurer<EipPacket> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(EipPacket.class, EipPacket::staticParse)
+        return SingleProtocolStackConfigurer.builder(EipPacket.class, io -> EipPacket.staticParse(io, true))
             .withProtocol(EipProtocolLogic.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)
-            .withParserArgs(true)
             .withCorruptPacketRemover(CorruptPackageCleaner.class)
             .littleEndian()
             .build();

diff --git a/.../drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/FirmataDriver.java b/.../drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/FirmataDriver.java
@@ -96,13 +96,11 @@ protected boolean awaitDisconnectComplete() {
 
     @Override
     protected ProtocolStackConfigurer<FirmataMessage> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(FirmataMessage.class, FirmataMessage::staticParse)
+        return SingleProtocolStackConfigurer.builder(FirmataMessage.class, io -> FirmataMessage.staticParse(io, true))
             .withProtocol(FirmataProtocolLogic.class)
             .withDriverContext(FirmataDriverContext.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)
             .withCorruptPacketRemover(CorruptPackageCleaner.class)
-            // Every incoming message is to be treated as a response.
-            .withParserArgs(true)
             .build();
     }
 

diff --git a/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/ascii/ModbusAsciiDriver.java b/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/ascii/ModbusAsciiDriver.java
@@ -133,13 +133,10 @@ protected org.apache.plc4x.java.api.value.PlcValueHandler getValueHandler() {
 
     @Override
     protected ProtocolStackConfigurer<ModbusAsciiADU> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(ModbusAsciiADU.class,
-                new ModbusAsciiInput(), new ModbusAsciiOutput())
+        return SingleProtocolStackConfigurer.builder(ModbusAsciiADU.class, new ModbusAsciiInput(), new ModbusAsciiOutput())
             .withProtocol(ModbusAsciiProtocolLogic.class)
             .withPacketSizeEstimator(ModbusAsciiDriver.ByteLengthEstimator.class)
             .withCorruptPacketRemover(ModbusAsciiDriver.CorruptPackageCleaner.class)
-            // Every incoming message is to be treated as a response.
-            .withParserArgs(DriverType.MODBUS_ASCII, true)
             .build();
     }
 
@@ -160,7 +157,7 @@ public int applyAsInt(ByteBuf byteBuf) {
                 // Try to parse the buffer content.
                 try {
                     ModbusAsciiInput input = new ModbusAsciiInput();
-                    ModbusAsciiADU modbusADU = input.parse(reader, DriverType.MODBUS_ASCII, true);
+                    ModbusAsciiADU modbusADU = input.parse(reader);
 
                     // Make sure we only read one message.
                     return (modbusADU.getLengthInBytes() * 2) + 3;
@@ -198,7 +195,7 @@ public ModbusTag prepareTag(String tagAddress){
 
     public static class ModbusAsciiInput implements MessageInput<ModbusAsciiADU> {
         @Override
-        public ModbusAsciiADU parse(ReadBuffer io, Object... args) throws ParseException {
+        public ModbusAsciiADU parse(ReadBuffer io) throws ParseException {
             // A Modbus ASCII message starts with an ASCII character ":" and is ended by two characters CRLF
             // (Carriage-Return + Line-Feed)
             // The actual payload is that each byte of the message is encoded by a string representation of it's
@@ -228,7 +225,7 @@ public ModbusAsciiADU parse(ReadBuffer io, Object... args) throws ParseException
 
     public static class ModbusAsciiOutput implements MessageOutput<ModbusAsciiADU> {
         @Override
-        public WriteBufferByteBased serialize(ModbusAsciiADU value, Object... args) throws SerializationException {
+        public WriteBufferByteBased serialize(ModbusAsciiADU value) throws SerializationException {
             // First serialize the packet the normal way.
             WriteBufferByteBased writeBufferByteBased = new WriteBufferByteBased(value.getLengthInBytes());
             value.serialize(writeBufferByteBased);

diff --git a/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/rtu/ModbusRtuDriver.java b/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/rtu/ModbusRtuDriver.java
@@ -32,6 +32,7 @@
 import org.apache.plc4x.java.spi.connection.GeneratedDriverBase;
 import org.apache.plc4x.java.spi.connection.ProtocolStackConfigurer;
 import org.apache.plc4x.java.spi.connection.SingleProtocolStackConfigurer;
+import org.apache.plc4x.java.spi.generation.MessageInput;
 import org.apache.plc4x.java.spi.generation.ParseException;
 import org.apache.plc4x.java.spi.generation.ReadBufferByteBased;
 import org.apache.plc4x.java.spi.optimizer.BaseOptimizer;
@@ -129,12 +130,9 @@ protected org.apache.plc4x.java.api.value.PlcValueHandler getValueHandler() {
 
     @Override
     protected ProtocolStackConfigurer<ModbusRtuADU> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(ModbusRtuADU.class,
-                (io, args) -> (ModbusRtuADU) ModbusRtuADU.staticParse(io, args))
+        return SingleProtocolStackConfigurer.builder(ModbusRtuADU.class, io -> (ModbusRtuADU) ModbusRtuADU.staticParse(io, DriverType.MODBUS_RTU, true))
             .withProtocol(ModbusRtuProtocolLogic.class)
             .withPacketSizeEstimator(ModbusRtuDriver.ByteLengthEstimator.class)
-            // Every incoming message is to be treated as a response.
-            .withParserArgs(DriverType.MODBUS_RTU, true)
             .build();
     }
 

diff --git a/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/tcp/ModbusTcpDriver.java b/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/tcp/ModbusTcpDriver.java
@@ -134,12 +134,9 @@ protected org.apache.plc4x.java.api.value.PlcValueHandler getValueHandler() {
 
     @Override
     protected ProtocolStackConfigurer<ModbusTcpADU> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(ModbusTcpADU.class,
-                (io, args) -> (ModbusTcpADU) ModbusTcpADU.staticParse(io, args))
+        return SingleProtocolStackConfigurer.builder(ModbusTcpADU.class, (io) -> (ModbusTcpADU) ModbusTcpADU.staticParse(io, DriverType.MODBUS_TCP, true))
             .withProtocol(ModbusTcpProtocolLogic.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)
-            // Every incoming message is to be treated as a response.
-            .withParserArgs(DriverType.MODBUS_TCP, true)
             .build();
     }
 

diff --git a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/OpcuaPlcDriver.java b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/OpcuaPlcDriver.java
@@ -107,10 +107,9 @@ protected boolean awaitDiscoverComplete() {
 
     @Override
     protected ProtocolStackConfigurer<OpcuaAPU> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(OpcuaAPU.class, OpcuaAPU::staticParse)
+        return SingleProtocolStackConfigurer.builder(OpcuaAPU.class, io -> OpcuaAPU.staticParse(io, true))
             .withProtocol(OpcuaProtocolLogic.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)
-            .withParserArgs(true)
             .withDriverContext(OpcuaDriverContext.class)
             .littleEndian()
             .build();

diff --git a/...vers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/chunk/PayloadConverter.java b/...vers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/chunk/PayloadConverter.java
@@ -81,9 +81,9 @@ public static Payload fromStream(byte[] payload, boolean extensible) throws Pars
         return Payload.staticParse(buffer, extensible, (long) (extensible ? -1 : payload.length - 8));
     }
 
-    public static MessagePDU fromStream(ByteBuffer chunkBuffer, boolean response, boolean encrypted) throws ParseException {
+    public static MessagePDU fromStream(ByteBuffer chunkBuffer, boolean response) throws ParseException {
         ReadBufferByteBased buffer = new ReadBufferByteBased(chunkBuffer.array(), ByteOrder.LITTLE_ENDIAN);
-        return MessagePDU.staticParse(buffer, response, encrypted);
+        return MessagePDU.staticParse(buffer, response);
     }
 
     public static MessagePDU pduFromStream(byte[] message, boolean response) throws ParseException {

diff --git a/...rs/open-protocol/src/main/java/org/apache/plc4x/java/openprotocol/OpenProtocolDriver.java b/...rs/open-protocol/src/main/java/org/apache/plc4x/java/openprotocol/OpenProtocolDriver.java
@@ -112,8 +112,7 @@ protected org.apache.plc4x.java.api.value.PlcValueHandler getValueHandler() {
 
     @Override
     protected ProtocolStackConfigurer<OpenProtocolMessage> getStackConfigurer() {
-        return SingleProtocolStackConfigurer.builder(OpenProtocolMessage.class,
-                OpenProtocolMessage::staticParse)
+        return SingleProtocolStackConfigurer.builder(OpenProtocolMessage.class, io -> OpenProtocolMessage.staticParse(io, 1))
             .withProtocol(OpenProtocolProtocolLogic.class)
             .withPacketSizeEstimator(ByteLengthEstimator.class)
             .build();

diff --git a/plc4j/drivers/profinet/src/main/java/org/apache/plc4x/java/profinet/ProfinetDriver.java b/plc4j/drivers/profinet/src/main/java/org/apache/plc4x/java/profinet/ProfinetDriver.java
@@ -151,7 +151,6 @@ protected ProtocolStackConfigurer<Ethernet_Frame> getStackConfigurer() {
             .withProtocol(ProfinetProtocolLogic.class)
             .withDriverContext(ProfinetDriverContext.class)
             // Every incoming message is to be treated as a response.
-            .withParserArgs(true)
             .build();
     }
 

diff --git a/...in/java/org/apache/plc4x/java/s7/readwrite/protocol/S7HSingleProtocolStackConfigurer.java b/...in/java/org/apache/plc4x/java/s7/readwrite/protocol/S7HSingleProtocolStackConfigurer.java
@@ -60,7 +60,6 @@ public class S7HSingleProtocolStackConfigurer<BASE_PACKET_CLASS extends Message>
     private final Class<? extends ToIntFunction<ByteBuf>> packetSizeEstimatorClass;
     private final Class<? extends Consumer<ByteBuf>> corruptPacketRemoverClass;
     private final MessageToMessageCodec<ByteBuf, ByteBuf> encryptionHandler;
-    private final Object[] parserArgs;
 
     private Plc4xProtocolBase<BASE_PACKET_CLASS> protocol = null;
 
@@ -77,7 +76,6 @@ public static <BPC extends Message> S7HSingleProtocolStackBuilder<BPC> builder(C
      */
     S7HSingleProtocolStackConfigurer(Class<BASE_PACKET_CLASS> basePacketClass,
                                      ByteOrder byteOrder,
-                                     Object[] parserArgs,
                                      Class<? extends Plc4xProtocolBase<BASE_PACKET_CLASS>> protocol,
                                      Class<? extends DriverContext> driverContextClass,
                                      MessageInput<BASE_PACKET_CLASS> messageInput,
@@ -87,7 +85,6 @@ public static <BPC extends Message> S7HSingleProtocolStackBuilder<BPC> builder(C
                                      MessageToMessageCodec<ByteBuf, ByteBuf> encryptionHandler) {
         this.basePacketClass = basePacketClass;
         this.byteOrder = byteOrder;
-        this.parserArgs = parserArgs;
         this.protocolClass = protocol;
         this.driverContextClass = driverContextClass;
         this.messageInput = messageInput;
@@ -98,7 +95,7 @@ public static <BPC extends Message> S7HSingleProtocolStackBuilder<BPC> builder(C
     }
 
     private ChannelHandler getMessageCodec(PlcConnectionConfiguration configuration) {
-        return new GeneratedProtocolMessageCodec<>(basePacketClass, messageInput, messageOutput, byteOrder, parserArgs,
+        return new GeneratedProtocolMessageCodec<>(basePacketClass, messageInput, messageOutput, byteOrder,
             packetSizeEstimatorClass != null ? configure(configuration, createInstance(packetSizeEstimatorClass)) : null,
             corruptPacketRemoverClass != null ? configure(configuration, createInstance(corruptPacketRemoverClass)) : null);
     }
@@ -154,7 +151,6 @@ public static final class S7HSingleProtocolStackBuilder<BASE_PACKET_CLASS extend
         private final MessageOutput<BASE_PACKET_CLASS> messageOutput;
         private Class<? extends DriverContext> driverContextClass;
         private ByteOrder byteOrder = ByteOrder.BIG_ENDIAN;
-        private Object[] parserArgs;
         private Class<? extends Plc4xProtocolBase<BASE_PACKET_CLASS>> protocol;
         private Class<? extends ToIntFunction<ByteBuf>> packetSizeEstimator;
         private Class<? extends Consumer<ByteBuf>> corruptPacketRemover;
@@ -186,11 +182,6 @@ public S7HSingleProtocolStackBuilder<BASE_PACKET_CLASS> littleEndian() {
             return this;
         }
 
-        public S7HSingleProtocolStackBuilder<BASE_PACKET_CLASS> withParserArgs(Object... parserArgs) {
-            this.parserArgs = parserArgs;
-            return this;
-        }
-
         public S7HSingleProtocolStackBuilder<BASE_PACKET_CLASS> withProtocol(Class<? extends Plc4xProtocolBase<BASE_PACKET_CLASS>> protocol) {
             this.protocol = protocol;
             return this;
@@ -213,7 +204,7 @@ public S7HSingleProtocolStackBuilder<BASE_PACKET_CLASS> withEncryptionHandler(Me
 
         public S7HSingleProtocolStackConfigurer<BASE_PACKET_CLASS> build() {
             assert this.protocol != null;
-            return new S7HSingleProtocolStackConfigurer<>(basePacketClass, byteOrder, parserArgs, protocol,
+            return new S7HSingleProtocolStackConfigurer<>(basePacketClass, byteOrder, protocol,
                 driverContextClass, messageInput, messageOutput, packetSizeEstimator, corruptPacketRemover,
                 encryptionHandler);
         }

diff --git a/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/GeneratedDriverByteToMessageCodec.java b/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/GeneratedDriverByteToMessageCodec.java
@@ -33,17 +33,15 @@ public abstract class GeneratedDriverByteToMessageCodec<T extends Message> exten
     private static final Logger LOGGER = LoggerFactory.getLogger(GeneratedDriverByteToMessageCodec.class);
 
     private final ByteOrder byteOrder;
-    private final Object[] parserArgs;
     private final MessageInput<T> messageInput;
     private final MessageOutput<T> messageOutput;
 
     protected GeneratedDriverByteToMessageCodec(MessageInput<T> messageInput, MessageOutput<T> messageOutput,
-                                                Class<T> outboundMessageType, ByteOrder byteOrder, Object[] parserArgs) {
+                                                Class<T> outboundMessageType, ByteOrder byteOrder) {
         super(outboundMessageType);
         this.messageInput = messageInput;
         this.messageOutput = messageOutput;
         this.byteOrder = byteOrder;
-        this.parserArgs = parserArgs;
     }
 
     @Override
@@ -84,7 +82,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf byteBuf, List<Object> o
                 ReadBuffer readBuffer = new ReadBufferByteBased(bytes, byteOrder);
 
                 // Parse the packet.
-                T packet = messageInput.parse(readBuffer, parserArgs);
+                T packet = messageInput.parse(readBuffer);
 
                 // Pass the packet to the pipeline.
                 out.add(packet);

diff --git a/...spi/src/main/java/org/apache/plc4x/java/spi/connection/CustomProtocolStackConfigurer.java b/...spi/src/main/java/org/apache/plc4x/java/spi/connection/CustomProtocolStackConfigurer.java
@@ -84,7 +84,7 @@ public static <BPC extends Message> CustomProtocolStackBuilder<BPC> builder(Clas
     }
 
     private ChannelHandler getMessageCodec(PlcConnectionConfiguration configuration) {
-        return new GeneratedProtocolMessageCodec<>(basePacketClass, protocolIO.apply(configuration), byteOrder, parserArgs,
+        return new GeneratedProtocolMessageCodec<>(basePacketClass, protocolIO.apply(configuration), byteOrder,
             packetSizeEstimator == null ? null : packetSizeEstimator.apply(configuration),
             corruptPacketRemover == null ? null : corruptPacketRemover.apply(configuration));
     }

diff --git a/...spi/src/main/java/org/apache/plc4x/java/spi/connection/GeneratedProtocolMessageCodec.java b/...spi/src/main/java/org/apache/plc4x/java/spi/connection/GeneratedProtocolMessageCodec.java
@@ -34,10 +34,9 @@ public GeneratedProtocolMessageCodec(
         Class<BASE_PACKET_CLASS> basePacketClass,
         MessageInput<BASE_PACKET_CLASS> messageInput,
         ByteOrder byteOrder,
-        Object[] parserArgs,
         ToIntFunction<ByteBuf> packetSizeEstimator,
         Consumer<ByteBuf> corruptPackageRemover) {
-        super(messageInput, null, basePacketClass, byteOrder, parserArgs);
+        super(messageInput, null, basePacketClass, byteOrder);
         this.packetSizeEstimator = packetSizeEstimator;
         this.corruptPackageRemover = corruptPackageRemover;
     }
@@ -47,10 +46,9 @@ public GeneratedProtocolMessageCodec(
         MessageInput<BASE_PACKET_CLASS> messageInput,
         MessageOutput<BASE_PACKET_CLASS> messageOutput,
         ByteOrder byteOrder,
-        Object[] parserArgs,
         ToIntFunction<ByteBuf> packetSizeEstimator,
         Consumer<ByteBuf> corruptPackageRemover) {
-        super(messageInput, messageOutput, basePacketClass, byteOrder, parserArgs);
+        super(messageInput, messageOutput, basePacketClass, byteOrder);
         this.packetSizeEstimator = packetSizeEstimator;
         this.corruptPackageRemover = corruptPackageRemover;
     }