upgrade protobuf/protoc to 3.25.3 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
requested review from
raboof,
gmethvin,
He-Pin,
mdedetrich and
Roiocam
raboof
approved these changes
Apr 6, 2024
| val googleProtoc = "3.24.0" // checked synced by VersionSyncCheckPlugin | ||
| val googleProtobufJava = "3.24.4" | ||
| val googleProtoc = "3.25.3" // checked synced by VersionSyncCheckPlugin | ||
| val googleProtobufJava = "3.25.3" |
There was a problem hiding this comment.
can we drop googleProtobufJava now that they're in sync again?
There was a problem hiding this comment.
I've set one to equal the other.
I think it is useful to have 3 props as it has gotten us out of jail before.
ScalaSteward is not going to generate correct PRs for us because the values also appear in Grade and Maven files too.
There was a problem hiding this comment.
I did try to edit on my phone but edit seems to have failed. I will try again later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala-steward doesn't upgrade protoc