Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2344: Bump to Thrift 0.19.0 #214

Merged
merged 2 commits into from
Sep 4, 2023
Merged

PARQUET-2344: Bump to Thrift 0.19.0 #214

merged 2 commits into from
Sep 4, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 3, 2023

Make sure you have checked all steps below.

This should support Java 8 again

Jira

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@Fokko Fokko changed the title Bump to Thrift 0.19.0 PARQUET-2344: Bump to Thrift 0.19.0 Sep 3, 2023
@rdblue rdblue merged commit c8f7f94 into master Sep 4, 2023
4 checks passed
@rdblue
Copy link
Contributor

rdblue commented Sep 4, 2023

Thanks, @Fokko! Good to be unblocked for thrift updates.

@Fokko Fokko deleted the fd-bumpthrifttt branch September 4, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants