Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/arm64: syscall SYS_switch_context and SYS_restore_context use tcb as parm #14739

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

lipengfei28
Copy link
Contributor

sys_call2(SYS_switch_context, (uintptr_t)rtcb, (uintptr_t)tcb)
sys_call1(SYS_restore_context, (uintptr_t)next)

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

@github-actions github-actions bot added Arch: arm64 Issues related to ARM64 (64-bit) architecture Size: S The size of the change in this PR is small labels Nov 12, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 12, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements. The provided information is essentially placeholder text copied from the template. It lacks critical details about the actual changes being made. Specifically, the following sections are incomplete:

  • Summary: Completely missing the why, what, and how of the change. The two lines of code provide no context.
  • Impact: All impact assessments are left as placeholders. Without knowing the change, impact cannot be assessed.
  • Testing: Completely missing build host, target details, and before/after testing logs. The current "testing logs" are just function calls and not actual logs.

The submitter needs to fill out these sections completely with specific details about their change before the PR can be considered. Just including the function calls sys_call2(SYS_switch_context, ...) and sys_call1(SYS_restore_context, ...) doesn't explain anything about the purpose or effect of the change.

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Nov 12, 2024

@pussuw could you review? I can't add you to the reviewer list, do you join github Apache group?

@pussuw
Copy link
Contributor

pussuw commented Nov 12, 2024

@pussuw could you review? I can't add you to the reviewer list, do you join github Apache group?

Yes, maybe there is something I forgot to do. I'll check later today.

Copy link
Contributor

@pussuw pussuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should arch/arm64/src/common/arm64_syscall.c be updated too ?

Copy link
Contributor

@pussuw pussuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lipengfei28 is there something missing from this patch ?

arch/arm64/include/irq.h Outdated Show resolved Hide resolved
@lipengfei28 lipengfei28 force-pushed the arm64_syscall branch 2 times, most recently from ccf433b to ee5b9d6 Compare November 13, 2024 01:56
@lipengfei28
Copy link
Contributor Author

d arch/arm64/src/common/arm64_syscall.c be updated too ?

done

arch/arm64/include/irq.h Outdated Show resolved Hide resolved
@lipengfei28 lipengfei28 force-pushed the arm64_syscall branch 5 times, most recently from 26efdf3 to c2c0b73 Compare November 13, 2024 06:40
arch/arm64/include/irq.h Outdated Show resolved Hide resolved
…b as

parm

sys_call2(SYS_switch_context, (uintptr_t)rtcb, (uintptr_t)tcb)
sys_call1(SYS_restore_context, (uintptr_t)next)

Signed-off-by: lipengfei28 <[email protected]>
Copy link
Contributor

@pussuw pussuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxiang781216 xiaoxiang781216 merged commit daab676 into apache:master Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm64 Issues related to ARM64 (64-bit) architecture Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants