-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/arm64: syscall SYS_switch_context and SYS_restore_context use tcb as parm #14739
Conversation
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. The provided information is essentially placeholder text copied from the template. It lacks critical details about the actual changes being made. Specifically, the following sections are incomplete:
The submitter needs to fill out these sections completely with specific details about their change before the PR can be considered. Just including the function calls |
@pussuw could you review? I can't add you to the reviewer list, do you join github Apache group? |
Yes, maybe there is something I forgot to do. I'll check later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should arch/arm64/src/common/arm64_syscall.c be updated too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lipengfei28 is there something missing from this patch ?
ccf433b
to
ee5b9d6
Compare
done |
26efdf3
to
c2c0b73
Compare
…b as parm sys_call2(SYS_switch_context, (uintptr_t)rtcb, (uintptr_t)tcb) sys_call1(SYS_restore_context, (uintptr_t)next) Signed-off-by: lipengfei28 <[email protected]>
c2c0b73
to
eaa8016
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sys_call2(SYS_switch_context, (uintptr_t)rtcb, (uintptr_t)tcb)
sys_call1(SYS_restore_context, (uintptr_t)next)
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.