Fix open maven subproject context menu #7723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Maven
attempt to fix UI issue of not selectable sub context menu on some configurations (wayland+flatlaf). Lazy init logic will create the JPopupMenu only once now.
mbien
force-pushed
the
fix-maven-subproject-context-menu
branch
from
0a2287e
to
2c99e0f
Compare
sdedic
approved these changes
Sep 3, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix UI issue of not selectable sub context menu on some configurations (wayland+flatlaf).
Lazy init logic will create the
JPopupMenuonly once now. It appears the problem was caused by changing the menu between consecutivegetJPopupMenu()calls. Debugging showed that the menu was created 5 times every time it popped up - this wasn't necessary.This change affects only the "Open Required Projects" maven sub-context menu, so it is fairly isolated from everything else -> should be low risk for NB 23.
fixes #7720