Fix build issues for NetBeans Language Server VSCode extension on Windows platform #7709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
added
LSP
|
Can anybody please re-trigger failed tests for this PR? |
lahodaj
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses build issues for the NetBeans Language Server VSCode extension on the Windows platform.
Ant Targets: Certain Ant targets, such as
ant build-vscode-ext, were failing on Windows due to missing suffixes required by the Windows environment. This has been corrected to ensure compatibility.NPM Compile Script: The
npm run compilecommand was not functioning correctly on Windows due to delimiter issues. This PR fixes the delimiter handling, allowing the command to run successfully on Windows.Changes Made
npm run compilescript to handle delimiter issue.