Checkbox support on Markdown preview #6401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What label would you like to add? |
I believe Editor and dependencies would be good. |
lkishalmi
reviewed
Sep 4, 2023
lkishalmi
approved these changes
Sep 4, 2023
mbien
approved these changes
Sep 22, 2023
mbien
reviewed
Sep 22, 2023
ide/markdown/src/org/netbeans/modules/markdown/ui/preview/views/ViewUtils.java
Outdated
Show resolved
Hide resolved
Markdown Preview * Support checkbox on preview * A utils class to handle some Html Elements * A custom MarkdownEditorKit * A MarkdownViewFactory to create custom views for preview. * Update dependecy FlexMark library from 1.14 to 1.15. Fix public-packages declaration to just use subpackages. Included flexmark-ext-gfm-tasklist-0.62.2.jar to license file. Removed non necessary utility class.
moacirrf
force-pushed
the
ft-markdown-checkbox
branch
from
081e917
to
5d92f5d
Compare
Done! |
|
@moacirrf congrats to your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Checkbox on Markdown Preview and some other changes that i will explain.
Project: Markdown Support
Added a package ui.preview and and ui.preview.views
MarkdownEditorKit.java : Is reponsible to supply a custom ViewFactory and this class has a very interesting method called getStyleSheet that is important to deal with themes on JEditorPane, so i believe that was better extract to a new class to avoid use of Anonymous class.
MarkdownViewFactory : Is responsible to create custom views to JEditorPane, it will receive a Html element and convert to the most similar swing component.
ViewUtils.java: Just a utility class to deal with HTML elements.
CheckboxView.java: A view of a Checkbox in this example was necessary create a custom just to preserve state checked and fix some border
Project: Markdown Library
Added flexmark-ext-gfm-tasklist to support of checkboxes.
Ps.: I do not have option to add a Label...