Pass DB connection details using file instead of env. variables #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thurka
added
LSP
thurka
added
the
do not merge
thurka
changed the title
thurka
force-pushed
the
GCN-3053
branch
6 times, most recently
from
5daba6f
to
c9d4e42
Compare
thurka
changed the title
thurka
removed
the
do not merge
MartinBalin
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses temporaty file to pass DB connection details. The file is created in subdirectory of OS temporaty directory and has only minimal (read) permission for user running NBLS.Other system users does not have even read permission (this is similar to ssh private key files. If the setting of correct permissions fails, the file the temporary file is deleted immediatelly. The temporaty file is deleted as soon as debugging session ends. If the NBLS and VScode are hard killed and the temporary file remains on filesystem, it is deleted on the subsequent startup of NBLS.