-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from setup.py to pyproject.toml #1929
Migrate from setup.py to pyproject.toml #1929
Conversation
5f19fd8
to
9d15c48
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #1929 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 353 353
Lines 81365 81387 +22
Branches 8598 8601 +3
=======================================
+ Hits 67630 67652 +22
Misses 10931 10931
Partials 2804 2804
|
^ @rsnk96 Just a heads up since you made a similar change recently by moving most of the tooling config into pyproject.toml. This change is still very much work in progress, but I just wanted to give you a heads up. |
setup.py test command.
I checked and tests the artifacts and they appear to be looking and working fine. For the time being, I will leave simple mainimal Alternative without that minimal setup.py file would be much more complicated (especially since we rely on dynamic version functionality in pyproject.toml). |
setuptools pyproject.yaml related warning.
…ami/libcloud into migrate_from_setuppy_to_pyproject_toml
This pull request is a work in progress attempt at trying to migrate package and build metadata from setup.py to pyproject.toml.
It will take some time to polish out all the kinks to ensure produced sdist and wheel artifacts match what would have been produced by the previous setup.oy config.
As part of this change, running tests directly via
python setup.py test
will be deprecated and removed (https://docs.pytest.org/en/7.2.x/explanation/goodpractices.html#do-not-run-via-setuptools) - I will document that in the changelog and update the affected readme.TODO