Remove deprecated and unused ApiDocs command from setup.py #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils.core.Command has also been deprecated and removed in Python 3.12.
|
Keep in mind that this is just the first step. To get dist steps to pass under Python 3.12, we will need to get rid of setup.py all together and replace it with packaging metadata in setup.cfg / pyproject.toml file. |
Codecov Report
@@ Coverage Diff @@
## trunk #1925 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 353 353
Lines 81366 81366
Branches 8598 8598
=======================================
Hits 67631 67631
Misses 10931 10931
Partials 2804 2804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes deprecated and unused "apidocs" command from setup.py (apidocs are being generated using sphinx for a long time already).
This way it also removes dependency on
distutils.core.Commandwhich is not available anymore in Python 3.12.