Merge pull request #1983 from FHPC-CNIC/improve-kubevirt-node-driver

Enhance `KubeVirtNodeDriver` Compute Driver
apache · Jun 20, 2024 · 52ad4a2 · 52ad4a2
2 parents 5fbf5bf + 7d7c102
commit 52ad4a2
Show file tree

Hide file tree

Showing 11 changed files with 2,632 additions and 240 deletions.
diff --git a/docs/compute/_supported_methods_main.rst b/docs/compute/_supported_methods_main.rst
@@ -26,7 +26,7 @@ Provider                       list nodes create node reboot node destroy node s
 `InternetSolutions`_           yes        yes         yes         yes          yes        yes       yes         yes        yes        
 `Kamatera`_                    yes        yes         yes         yes          yes        yes       yes         yes        yes        
 `KTUCloud`_                    yes        yes         yes         yes          no         no        yes         yes        yes        
-`kubevirt`_                    yes        yes         yes         yes          yes        yes       yes         yes        no         
+`kubevirt`_                    yes        yes         yes         yes          yes        yes       yes         yes        yes        
 `Libvirt`_                     yes        no          yes         yes          yes        yes       no          no         no         
 `Linode`_                      yes        yes         yes         yes          yes        yes       yes         yes        no         
 `Maxihost`_                    yes        yes         yes         yes          yes        yes       yes         yes        no         

diff --git a/docs/upgrade_notes.rst b/docs/upgrade_notes.rst
@@ -30,6 +30,38 @@ Libcloud 3.9.0
   If your code is using those arguments / passing them to the `create_node()`
   method it needs to be updated and those arguments removed.
 
+* [KubeVirt] Changes to the `create_node()` method: 
+
+  - The `ports` argument has been renamed to `ex_ports`. 
+  - The `ex_disks` argument has been redefined to support all volume types. 
+
+  The deprecated `ex_disks` format, which only supports `PersistentVolumeClaim`,
+  is as follows:
+
+  .. sourcecode:: python
+
+    ex_disks=[{"bus": "", "device": "", "disk_type": "", "name": "", "claim_name": "", "size": "", "storage_class_name": "", "volume_mode": "", "access_mode": ""}]
+
+  The new format is:
+
+  .. sourcecode:: python
+
+    ex_disks=[{"bus": "", "device": "", "disk_type": "", "name": "", "volume_spec": {...}}]
+
+  Here, `volume_spec` is the `disk_type` specific settings, which aligns with the 
+  KubeVirt user guide on disks and volumes 
+  (https://kubevirt.io/user-guide/virtual_machines/disks_and_volumes). 
+
+  For example, for PVC:
+
+  .. sourcecode:: python
+
+    ex_disks=[{ ..., "volume_spec": {{"claim_name": "", "size": "", "storage_class_name": "", "volume_mode": "", "access_mode": ""} }]
+
+  If your code uses these arguments or passes them to the `create_node()`
+  method, it will need to be updated accordingly.
+
+
 Libcloud 3.8.0
 --------------